Bug 230154 - net/librsync2: Update 2.0.0 => v2.0.2; Also fixes build
Summary: net/librsync2: Update 2.0.0 => v2.0.2; Also fixes build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bryan Drewery
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2018-07-29 17:36 UTC by Nathan
Modified: 2018-10-04 18:48 UTC (History)
3 users (show)

See Also:
bdrewery: maintainer-feedback+


Attachments
Update/Remove perl as dep according to RelNotes (1.68 KB, patch)
2018-07-29 17:36 UTC, Nathan
no flags Details | Diff
Update/FIx (2.71 KB, patch)
2018-08-02 22:36 UTC, Nathan
no flags Details | Diff
Poudriere Log (43.57 KB, text/plain)
2018-08-02 22:37 UTC, Nathan
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan 2018-07-29 17:36:56 UTC
Created attachment 195599 [details]
Update/Remove perl as dep according to RelNotes

Release Notes:

    Improve CMake install paths configuration (wRAR, #133) and platform support checking when cross-compiling (fornwall, #136).

    Fix Unaligned memory access for rs_block_sig_init() (dbaarda, #135).

    Fix hashtable_test.c name collision for key_t in sys/types.h on some platforms (dbaarda, #134)

    Format code with consistent style, adding make tidy and make tidyc targets for reformating code and comments. (dbaarda, #125)

    Removed perl as a build dependency. Note it is still required for some tests. (dbaarda, #75)

    Update RPM spec file for v2.0.2 and fix cmake man page install. (deajan, #47)
Comment 1 Nathan 2018-08-02 22:36:27 UTC
Created attachment 195776 [details]
Update/FIx

Updates to latest version and also unbreaks current version, due to failed patch in current version in ports
Comment 2 Nathan 2018-08-02 22:37:23 UTC
Created attachment 195777 [details]
Poudriere Log

Portlint AC ok
Comment 3 Bryan Drewery freebsd_committer freebsd_triage 2018-09-13 22:23:47 UTC
"Fixes build" is confusing since there is no problem unless bumping to 2.0.2 which
then includes the patch you're removing.

It's committed now, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-09-13 22:25:11 UTC
A commit references this bug:

Author: bdrewery
Date: Thu Sep 13 22:24:15 UTC 2018
New revision: 479748
URL: https://svnweb.freebsd.org/changeset/ports/479748

Log:
  Update to 2.0.2

  PR:		230154
  Submitted by:	Nathan <ndowens@yahoo.com>

Changes:
  head/net/librsync2/Makefile
  head/net/librsync2/distinfo
  head/net/librsync2/files/
  head/net/librsync2/pkg-plist
Comment 5 Arnaud de Prelle 2018-09-14 14:59:32 UTC
I can't build the port on my system since this FIX :

root@icecube BSD:/usr/ports/net/librsync2 # make MAKE_JOBS_UNSAFE=yes install clean                                                                                                                                                            ===>  License LGPL21+ accepted by the user
===>   librsync2-2.0.2 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by librsync2-2.0.2 for building
===>  Extracting for librsync2-2.0.2
=> SHA256 Checksum OK for librsync-librsync-v2.0.2_GH0.tar.gz.
===>  Patching for librsync2-2.0.2
===>   librsync2-2.0.2 depends on file: /usr/local/bin/cmake - found
===>   librsync2-2.0.2 depends on executable: ninja - found
===>   librsync2-2.0.2 depends on shared library: libpopt.so - found (/usr/local/lib/libpopt.so)
===>  Configuring for librsync2-2.0.2
===>  Performing in-source build
/bin/mkdir -p /usr/ports/net/librsync2/work/librsync-2.0.2
-- The C compiler identification is Clang 3.4.1
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- DO_RS_TRACE=0
-- Looking for include file alloca.h
-- Looking for include file alloca.h - not found
-- Looking for include file dlfcn.h
-- Looking for include file dlfcn.h - found
-- Looking for include file inttypes.h
-- Looking for include file inttypes.h - found
-- Looking for include file memory.h
-- Looking for include file memory.h - found
-- Looking for include file stdint.h
-- Looking for include file stdint.h - found
-- Looking for include file stdlib.h
-- Looking for include file stdlib.h - found
-- Looking for include file strings.h
-- Looking for include file strings.h - found
-- Looking for include file string.h
-- Looking for include file string.h - found
-- Looking for include file sys/stat.h
-- Looking for include file sys/stat.h - found
-- Looking for include file sys/types.h
-- Looking for include file sys/types.h - found
-- Looking for include file unistd.h
-- Looking for include file unistd.h - found
-- Looking for include file bzlib.h
-- Looking for include file bzlib.h - found
-- Looking for include file fcntl.h
-- Looking for include file fcntl.h - found
-- Looking for include file malloc.h
-- Looking for include file malloc.h - not found
-- Looking for include file mcheck.h
-- Looking for include file mcheck.h - not found
-- Looking for include file sys/file.h
-- Looking for include file sys/file.h - found
-- Looking for include file zlib.h
-- Looking for include file zlib.h - found
-- Looking for alloca
-- Looking for alloca - not found
-- Looking for fseeko
-- Looking for fseeko - found
-- Looking for fseeko64
-- Looking for fseeko64 - not found
-- Looking for _fseeki64
-- Looking for _fseeki64 - not found
-- Looking for fstat64
-- Looking for fstat64 - not found
-- Looking for _fstati64
-- Looking for _fstati64 - not found
-- Looking for fileno
-- Looking for fileno - found
-- Looking for _fileno
-- Looking for _fileno - not found
-- Looking for memmove
-- Looking for memmove - found
-- Looking for memset
-- Looking for memset - found
-- Looking for strchr
-- Looking for strchr - found
-- Looking for strerror
-- Looking for strerror - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of long
-- Check size of long - done
-- Check size of long long
-- Check size of long long - done
-- Check size of off_t
-- Check size of off_t - done
-- Check size of off64_t
-- Check size of off64_t - failed
-- Check size of size_t
-- Check size of size_t - done
-- Check size of unsigned int
-- Check size of unsigned int - done
-- Check size of unsigned long
-- Check size of unsigned long - done
-- Check size of unsigned short
-- Check size of unsigned short - done
-- Performing Test HAVE_PRINTF_Z
-- Performing Test HAVE_PRINTF_Z - Success
-- Check if the system is big endian
-- Searching 16 bit integer
-- Check size of unsigned short
-- Check size of unsigned short - done
-- Using unsigned short
-- Check if the system is big endian - little endian
-- System is little-endian.
-- PROJECT_NAME  = librsync
-- BUILD_HOSTNAME = icecube.pnzone.net
-- CMAKE_SYSTEM = FreeBSD-10.4-RELEASE-p8
-- Found POPT: /usr/local/lib/libpopt.so
-- Found components for POPT
-- POPT_ROOT_DIR  = /usr/local
-- POPT_INCLUDE_DIRS  = /usr/local/include
-- POPT_LIBRARIES = /usr/local/lib/libpopt.so
-- Found BZip2: /usr/lib/libbz2.so (found version "1.0.6")
-- Looking for BZ2_bzCompressInit
-- Looking for BZ2_bzCompressInit - found
-- Found components for BZIP2
-- BZIP2_INCLUDE_DIR  = /usr/include
-- BZIP2_LIBRARIES = /usr/lib/libbz2.so
-- Found ZLIB: /usr/lib/libz.so (found version "1.2.11")
-- Found components for ZLIB
-- ZLIB_INCLUDE_DIRS  = /usr/include
-- ZLIB_LIBRARIES = /usr/lib/libz.so
-- Could NOT find LIBB2 (missing: LIBB2_LIBRARIES LIBB2_INCLUDE_DIRS)
-- Using included blake2 implementation.
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
-- CMAKE_C_FLAGS  = -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_CXX_COMPILER
    CMAKE_CXX_FLAGS
    CMAKE_CXX_FLAGS_DEBUG
    CMAKE_CXX_FLAGS_RELEASE
    CMAKE_C_FLAGS_DEBUG
    CMAKE_MODULE_LINKER_FLAGS
    CMAKE_VERBOSE_MAKEFILE
    THREADS_HAVE_PTHREAD_ARG


-- Build files have been written to: /usr/ports/net/librsync2/work/librsync-2.0.2
===>  Building for librsync2-2.0.2
[1/53] /usr/bin/cc  -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -MD -MT CMakeFiles/rdiff.dir/src/rdiff.c.o -MF CMakeFiles/rdiff.dir/src/rdiff.c.o.d -o CMakeFiles/rdiff.dir/src/rdiff.c.o   -c src/rdiff.c
[2/53] /usr/bin/cc  -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -MD -MT CMakeFiles/rdiff.dir/src/isprefix.c.o -MF CMakeFiles/rdiff.dir/src/isprefix.c.o.d -o CMakeFiles/rdiff.dir/src/isprefix.c.o   -c src/isprefix.c
[3/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/prototab.c.o -MF CMakeFiles/rsync.dir/src/prototab.c.o.d -o CMakeFiles/rsync.dir/src/prototab.c.o   -c src/prototab.c
[4/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/base64.c.o -MF CMakeFiles/rsync.dir/src/base64.c.o.d -o CMakeFiles/rsync.dir/src/base64.c.o   -c src/base64.c
[5/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/buf.c.o -MF CMakeFiles/rsync.dir/src/buf.c.o.d -o CMakeFiles/rsync.dir/src/buf.c.o   -c src/buf.c
[6/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/checksum.c.o -MF CMakeFiles/rsync.dir/src/checksum.c.o.d -o CMakeFiles/rsync.dir/src/checksum.c.o   -c src/checksum.c
[7/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/command.c.o -MF CMakeFiles/rsync.dir/src/command.c.o.d -o CMakeFiles/rsync.dir/src/command.c.o   -c src/command.c
[8/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/delta.c.o -MF CMakeFiles/rsync.dir/src/delta.c.o.d -o CMakeFiles/rsync.dir/src/delta.c.o   -c src/delta.c
[9/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/emit.c.o -MF CMakeFiles/rsync.dir/src/emit.c.o.d -o CMakeFiles/rsync.dir/src/emit.c.o   -c src/emit.c
[10/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/fileutil.c.o -MF CMakeFiles/rsync.dir/src/fileutil.c.o.d -o CMakeFiles/rsync.dir/src/fileutil.c.o   -c src/fileutil.c
[11/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/hashtable.c.o -MF CMakeFiles/rsync.dir/src/hashtable.c.o.d -o CMakeFiles/rsync.dir/src/hashtable.c.o   -c src/hashtable.c
[12/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/hex.c.o -MF CMakeFiles/rsync.dir/src/hex.c.o.d -o CMakeFiles/rsync.dir/src/hex.c.o   -c src/hex.c
[13/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/job.c.o -MF CMakeFiles/rsync.dir/src/job.c.o.d -o CMakeFiles/rsync.dir/src/job.c.o   -c src/job.c
[14/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/mdfour.c.o -MF CMakeFiles/rsync.dir/src/mdfour.c.o.d -o CMakeFiles/rsync.dir/src/mdfour.c.o   -c src/mdfour.c
[15/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/mksum.c.o -MF CMakeFiles/rsync.dir/src/mksum.c.o.d -o CMakeFiles/rsync.dir/src/mksum.c.o   -c src/mksum.c
[16/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/msg.c.o -MF CMakeFiles/rsync.dir/src/msg.c.o.d -o CMakeFiles/rsync.dir/src/msg.c.o   -c src/msg.c
[17/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/netint.c.o -MF CMakeFiles/rsync.dir/src/netint.c.o.d -o CMakeFiles/rsync.dir/src/netint.c.o   -c src/netint.c
[18/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/patch.c.o -MF CMakeFiles/rsync.dir/src/patch.c.o.d -o CMakeFiles/rsync.dir/src/patch.c.o   -c src/patch.c
[19/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/readsums.c.o -MF CMakeFiles/rsync.dir/src/readsums.c.o.d -o CMakeFiles/rsync.dir/src/readsums.c.o   -c src/readsums.c
[20/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/rollsum.c.o -MF CMakeFiles/rsync.dir/src/rollsum.c.o.d -o CMakeFiles/rsync.dir/src/rollsum.c.o   -c src/rollsum.c
[21/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/scoop.c.o -MF CMakeFiles/rsync.dir/src/scoop.c.o.d -o CMakeFiles/rsync.dir/src/scoop.c.o   -c src/scoop.c
[22/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/stats.c.o -MF CMakeFiles/rsync.dir/src/stats.c.o.d -o CMakeFiles/rsync.dir/src/stats.c.o   -c src/stats.c
[23/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/stream.c.o -MF CMakeFiles/rsync.dir/src/stream.c.o.d -o CMakeFiles/rsync.dir/src/stream.c.o   -c src/stream.c
[24/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/sumset.c.o -MF CMakeFiles/rsync.dir/src/sumset.c.o.d -o CMakeFiles/rsync.dir/src/sumset.c.o   -c src/sumset.c
[25/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/trace.c.o -MF CMakeFiles/rsync.dir/src/trace.c.o.d -o CMakeFiles/rsync.dir/src/trace.c.o   -c src/trace.c
[26/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/tube.c.o -MF CMakeFiles/rsync.dir/src/tube.c.o.d -o CMakeFiles/rsync.dir/src/tube.c.o   -c src/tube.c
[27/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/util.c.o -MF CMakeFiles/rsync.dir/src/util.c.o.d -o CMakeFiles/rsync.dir/src/util.c.o   -c src/util.c
[28/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/version.c.o -MF CMakeFiles/rsync.dir/src/version.c.o.d -o CMakeFiles/rsync.dir/src/version.c.o   -c src/version.c
[29/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/whole.c.o -MF CMakeFiles/rsync.dir/src/whole.c.o.d -o CMakeFiles/rsync.dir/src/whole.c.o   -c src/whole.c
[30/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT CMakeFiles/rsync.dir/src/blake2/blake2b-ref.c.o -MF CMakeFiles/rsync.dir/src/blake2/blake2b-ref.c.o.d -o CMakeFiles/rsync.dir/src/blake2/blake2b-ref.c.o   -c src/blake2/blake2b-ref.c
[31/53] : && /usr/bin/cc -fPIC -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing  -fstack-protector -shared -Wl,-soname,librsync.so.2 -o librsync.so.2.0.2 CMakeFiles/rsync.dir/src/prototab.c.o CMakeFiles/rsync.dir/src/base64.c.o CMakeFiles/rsync.dir/src/buf.c.o CMakeFiles/rsync.dir/src/checksum.c.o CMakeFiles/rsync.dir/src/command.c.o CMakeFiles/rsync.dir/src/delta.c.o CMakeFiles/rsync.dir/src/emit.c.o CMakeFiles/rsync.dir/src/fileutil.c.o CMakeFiles/rsync.dir/src/hashtable.c.o CMakeFiles/rsync.dir/src/hex.c.o CMakeFiles/rsync.dir/src/job.c.o CMakeFiles/rsync.dir/src/mdfour.c.o CMakeFiles/rsync.dir/src/mksum.c.o CMakeFiles/rsync.dir/src/msg.c.o CMakeFiles/rsync.dir/src/netint.c.o CMakeFiles/rsync.dir/src/patch.c.o CMakeFiles/rsync.dir/src/readsums.c.o CMakeFiles/rsync.dir/src/rollsum.c.o CMakeFiles/rsync.dir/src/scoop.c.o CMakeFiles/rsync.dir/src/stats.c.o CMakeFiles/rsync.dir/src/stream.c.o CMakeFiles/rsync.dir/src/sumset.c.o CMakeFiles/rsync.dir/src/trace.c.o CMakeFiles/rsync.dir/src/tube.c.o CMakeFiles/rsync.dir/src/util.c.o CMakeFiles/rsync.dir/src/version.c.o CMakeFiles/rsync.dir/src/whole.c.o CMakeFiles/rsync.dir/src/blake2/blake2b-ref.c.o   && :
[32/53] /usr/local/bin/cmake -E cmake_symlink_library librsync.so.2.0.2  librsync.so.2 librsync.so && :
[33/53] : && /usr/bin/cc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing  -fstack-protector CMakeFiles/rdiff.dir/src/rdiff.c.o CMakeFiles/rdiff.dir/src/isprefix.c.o  -o rdiff  -Wl,-rpath,/usr/ports/net/librsync2/work/librsync-2.0.2:/usr/local/lib: librsync.so.2.0.2 /usr/local/lib/libpopt.so && :
[34/53] /usr/bin/cc  -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -MD -MT CMakeFiles/sumset_test.dir/tests/sumset_test.c.o -MF CMakeFiles/sumset_test.dir/tests/sumset_test.c.o.d -o CMakeFiles/sumset_test.dir/tests/sumset_test.c.o   -c tests/sumset_test.c
FAILED: CMakeFiles/sumset_test.dir/tests/sumset_test.c.o
/usr/bin/cc  -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe  -fstack-protector -fno-strict-aliasing -MD -MT CMakeFiles/sumset_test.dir/tests/sumset_test.c.o -MF CMakeFiles/sumset_test.dir/tests/sumset_test.c.o.d -o CMakeFiles/sumset_test.dir/tests/sumset_test.c.o   -c tests/sumset_test.c
In file included from tests/sumset_test.c:27:
/usr/local/include/librsync.h:430:21: error: unknown type name 'FILE'
void rs_mdfour_file(FILE *in_file, char *result);
                    ^
/usr/local/include/librsync.h:432:23: error: unknown type name 'FILE'
rs_result rs_sig_file(FILE *old_file, FILE *sig_file,
                      ^
/usr/local/include/librsync.h:432:39: error: unknown type name 'FILE'
rs_result rs_sig_file(FILE *old_file, FILE *sig_file,
                                      ^
/usr/local/include/librsync.h:437:27: error: unknown type name 'FILE'
rs_result rs_loadsig_file(FILE *, rs_signature_t **, rs_stats_t *);
                          ^
/usr/local/include/librsync.h:441:43: error: unknown type name 'FILE'
rs_result rs_delta_file(rs_signature_t *, FILE *new_file, FILE *delta_file, rs_stats_t *);
                                          ^
/usr/local/include/librsync.h:441:59: error: unknown type name 'FILE'
rs_result rs_delta_file(rs_signature_t *, FILE *new_file, FILE *delta_file, rs_stats_t *);
                                                          ^
/usr/local/include/librsync.h:443:25: error: unknown type name 'FILE'
rs_result rs_patch_file(FILE *basis_file, FILE *delta_file, FILE *new_file, rs_stats_t *);
                        ^
/usr/local/include/librsync.h:443:43: error: unknown type name 'FILE'
rs_result rs_patch_file(FILE *basis_file, FILE *delta_file, FILE *new_file, rs_stats_t *);
                                          ^
/usr/local/include/librsync.h:443:61: error: unknown type name 'FILE'
rs_result rs_patch_file(FILE *basis_file, FILE *delta_file, FILE *new_file, rs_stats_t *);
                                                            ^
9 errors generated.
ninja: build stopped: subcommand failed.
*** Error code 1

Stop.

root@icecube BSD:/usr/ports/net/librsync2 # cat /etc/make.conf
MYSQL_VER=101m
OPTIONS_UNSET=X11
DEFAULT_VERSIONS+=ssl=openssl
OPTIONS_UNSET=GSSAPI
KERNCONF=ICE3K
#DEVELOPER=yes

root@icecube BSD:/usr/ports/net/librsync2 # cat distinfo
TIMESTAMP = 1536872689
SHA256 (librsync-librsync-v2.0.2_GH0.tar.gz) = e67b9520ee84f7239be6e948795803bd95495091cc00bf6d0e8c6976032a4af1
SIZE (librsync-librsync-v2.0.2_GH0.tar.gz) = 174480

Am I missing something ?
Comment 6 Nathan 2018-09-14 16:45:14 UTC
(In reply to Arnaud de Prelle from comment #5)
Retried inside and outside of poudriere on 12 and64 and I get no errors.
Comment 7 Arnaud de Prelle 2018-09-14 18:03:41 UTC
(In reply to Nathan from comment #6)

Hi Nathan,

These are compilation issues (error: unknown type name 'FILE').
I'm running a regular FreeBSD 10.4 with default settings at compilation level (see make.conf above).

Most probably that C compiler is not compliant with the latest librsync2 update.

root@icecube BSD:/usr/ports/net/librsync2 # uname -a
FreeBSD icecube.pnzone.net 10.4-RELEASE-p8 FreeBSD 10.4-RELEASE-p8 #29 r332407: Wed Apr 11 17:20:07 CEST 2018     root@icecube.pnzone.net:/usr/obj/usr/src/sys/ICE3K  amd64

root@icecube BSD:/usr/ports/net/librsync2 # cc -v
FreeBSD clang version 3.4.1 (tags/RELEASE_34/dot1-final 208032) 20140512
Target: x86_64-unknown-freebsd10.4
Thread model: posix
Selected GCC installation: 

I'll try other settings than the default ones for this port compilation.
Comment 8 Arnaud de Prelle 2018-09-14 18:09:20 UTC
I solved this issue by appending this to my make.conf:
USE_GCC?=any

It's the first time I have to change the default system compiler for building a port...
I guess the Makefile of this port should be adapted in order to force this gcc dependency.
Comment 9 Arnaud de Prelle 2018-09-14 18:14:36 UTC
(In reply to apn from comment #8)

See https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html 
Section 5.9.8.
Comment 10 Peter Putzer 2018-09-15 06:50:45 UTC
(In reply to Nathan from comment #6)

I've got the same problem on 11.2-RELEASE-p3 on amd64. The build is broken.

In file included from tests/sumset_test.c:27:
/usr/local/include/librsync.h:430:21: error: unknown type name 'FILE'
void rs_mdfour_file(FILE *in_file, char *result);
                    ^
/usr/local/include/librsync.h:432:23: error: unknown type name 'FILE'
rs_result rs_sig_file(FILE *old_file, FILE *sig_file,
                      ^
/usr/local/include/librsync.h:432:39: error: unknown type name 'FILE'
rs_result rs_sig_file(FILE *old_file, FILE *sig_file,
                                      ^
/usr/local/include/librsync.h:437:27: error: unknown type name 'FILE'
rs_result rs_loadsig_file(FILE *, rs_signature_t **, rs_stats_t *);
                          ^
/usr/local/include/librsync.h:441:43: error: unknown type name 'FILE'
rs_result rs_delta_file(rs_signature_t *, FILE *new_file, FILE *delta_file, rs_stats_t *);
                                          ^
/usr/local/include/librsync.h:441:59: error: unknown type name 'FILE'
rs_result rs_delta_file(rs_signature_t *, FILE *new_file, FILE *delta_file, rs_stats_t *);
                                                          ^
/usr/local/include/librsync.h:443:25: error: unknown type name 'FILE'
rs_result rs_patch_file(FILE *basis_file, FILE *delta_file, FILE *new_file, rs_stats_t *);
                        ^
/usr/local/include/librsync.h:443:43: error: unknown type name 'FILE'
rs_result rs_patch_file(FILE *basis_file, FILE *delta_file, FILE *new_file, rs_stats_t *);
                                          ^
/usr/local/include/librsync.h:443:61: error: unknown type name 'FILE'
rs_result rs_patch_file(FILE *basis_file, FILE *delta_file, FILE *new_file, rs_stats_t *);
                                                            ^
9 errors generated.
Comment 11 Pavlos Georgiadis 2018-10-04 18:46:26 UTC
I am also getting the same "unknown type name 'FILE'" error on 11.2-RELEASE-p4.

I think this ticket needs to be re-opened.
Comment 12 Peter Putzer 2018-10-04 18:48:17 UTC
(In reply to Pavlos Georgiadis from comment #11)

There's a separate ticket for that now: bug #231373.