Bug 230583 - devel/libvirt: missing dependency devel/jansson
Summary: devel/libvirt: missing dependency devel/jansson
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Roman Bogorodskiy
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2018-08-13 03:15 UTC by hashiz
Modified: 2018-08-17 00:59 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (novel)
novel: merge-quarterly-

Attachments
patch (1.41 KB, patch)
2018-08-13 16:06 UTC, Roman Bogorodskiy 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hashiz 2018-08-13 03:15:25 UTC 
missing dependency devel/jansson
Comment 1 hashiz 2018-08-13 03:23:39 UTC 
--- devel/libvirt/Makefile.orig 2018-08-12 15:50:32.000000000 +0900
+++ devel/libvirt/Makefile      2018-08-13 12:14:13.387814000 +0900
@@ -14,7 +14,8 @@

 LIB_DEPENDS=   libcurl.so:ftp/curl \
                libgcrypt.so:security/libgcrypt \
-               libxml2.so:textproc/libxml2
+               libxml2.so:textproc/libxml2 \
+               libjansson.so:devel/jansson
 BUILD_DEPENDS= dnsmasq:dns/dnsmasq \
                xsltproc:textproc/libxslt
 RUN_DEPENDS=   dnsmasq:dns/dnsmasq
Comment 2 Vanilla I. Shu freebsd_committer freebsd_triage 2018-08-13 03:37:19 UTC 
novel is the maintainer of devel/libvirt, not me.
Comment 3 Roman Bogorodskiy freebsd_committer freebsd_triage 2018-08-13 16:05:59 UTC 
(In reply to hashiz from comment #1)

Bah, I didn't test the 'QEMU' option for quite some time, sorry about that. However, this requires some more changes. I'm attaching the patch I'm testing right now. Hope to commit tomorrow if there are no issues.
Comment 4 Roman Bogorodskiy freebsd_committer freebsd_triage 2018-08-13 16:06:26 UTC 
Created attachment 196164 [details]
patch
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-08-14 16:04:04 UTC 
A commit references this bug:

Author: novel
Date: Tue Aug 14 16:03:28 UTC 2018
New revision: 477167
URL: https://svnweb.freebsd.org/changeset/ports/477167

Log:
  devel/libvirt: fix build with QEMU enabled

  Libvirt has switched from yajl to jansson for JSON parsing,
  so update dependencies accordingly. Also add some missing
  directories to plist.

  Bump PORTREVISION.

  PR:		230583 (based on)
  Submitted by:	hashiz@meridiani.jp

Changes:
  head/devel/libvirt/Makefile
  head/devel/libvirt/pkg-plist
Comment 6 Roman Bogorodskiy freebsd_committer freebsd_triage 2018-08-15 06:11:06 UTC 
2018Q3 is not affected, so closing this one.

Thanks for reporting!
Comment 7 hashiz 2018-08-17 00:59:54 UTC 
(In reply to Roman Bogorodskiy from comment #6)
I confirmed fix, thanks.