Bug 230675 - editors/vim: Python 3.7 is not listed in the src-auto-configure patch
Summary: editors/vim: Python 3.7 is not listed in the src-auto-configure patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-16 19:22 UTC by Kamigishi Rei
Modified: 2018-08-26 19:53 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (adamw)


Attachments
auto-configure patch (502 bytes, patch)
2018-08-16 19:23 UTC, Kamigishi Rei
no flags Details | Diff
Sub in the correct python binary name (1.24 KB, patch)
2018-08-16 19:42 UTC, Adam Weinberger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kamigishi Rei 2018-08-16 19:22:10 UTC
Might be worth it to put `python3.9 python3.8` there as well?
Comment 1 Kamigishi Rei 2018-08-16 19:23:13 UTC
Created attachment 196258 [details]
auto-configure patch
Comment 2 Adam Weinberger freebsd_committer freebsd_triage 2018-08-16 19:42:26 UTC
Created attachment 196259 [details]
Sub in the correct python binary name

History shows pretty clearly that I will keep forgetting to add in new py3 versions, so I'd like to take that necessity out of the picture entirely.

Can you try out this instead? It determines the binary name for the current python version and just subs that in instead.
Comment 3 Kamigishi Rei 2018-08-16 19:53:27 UTC
It does seem to work perfectly well:

checking --with-python3-command argument... no
checking for python3.7... /usr/local/bin/python3.7
checking Python version... 3.7

Poudriere builds the package successfully and I am sure it will work fine. Thank you.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-08-16 21:04:44 UTC
A commit references this bug:

Author: adamw
Date: Thu Aug 16 21:04:02 UTC 2018
New revision: 477376
URL: https://svnweb.freebsd.org/changeset/ports/477376

Log:
  Improve the way vim looks for python binaries

  Previously, we patched in the names of all the python binary versions, but
  I have been doing a terrible job of keeping them up-to-date. Instead, just
  tell vim's configure script the path to the binary we're using.

  This will fix building against python 3.7.

  PR:		230675
  Reported by:	Kamigishi Rei
  MFH:		2018Q3

Changes:
  head/editors/vim/Makefile
  head/editors/vim/files/patch-src-auto-configure
Comment 5 Adam Weinberger freebsd_committer freebsd_triage 2018-08-16 21:07:20 UTC
Thank you for including the configure output! I just used --with-python3-command (and was able to do the same thing with --with-python-command). I feel much better about not having to worry about forgetting to update the list again (which I can absolutely guarantee was going to happen).

Because this is a build fix, I've requested an MFH.
Comment 6 Adam Weinberger freebsd_committer freebsd_triage 2018-08-26 19:53:22 UTC
Just FTR I decided against the MFH. Merging r476013 will touch over 200 ports, and python37 isn't in 2018Q3 anyway.