Bug 230710 - [patch] x11-fm/rox-filer: add missing dependencies and clean Makefile
Summary: [patch] x11-fm/rox-filer: add missing dependencies and clean Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-17 16:33 UTC by Samy Mahmoudi
Modified: 2018-08-17 18:13 UTC (History)
1 user (show)

See Also:
pi: maintainer-feedback+

Attachments
Patch file generated with svn diff (4.24 KB, patch)
2018-08-17 16:33 UTC, Samy Mahmoudi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samy Mahmoudi 2018-08-17 16:33:42 UTC 
Created attachment 196292 [details]
Patch file generated with svn diff

- Regenerate patch files with make makepatch.
- Remove useless assignment to DISTNAME.
- Add a lib dependency on print/freetype2
- Add a lib dependency on x11-fonts/fontconfig
- Add LICENSE= GPLv2+
- Move USES ahead of USE_*
- Add gettext-runtime:build to the USES variable
- Add ice to the variable USE_XORG and sort the corresponding list
- Add cairo and gdkpixbuf2 to the variable USE_GNOME
- Reindent the lines of the target post-configure
- Split a line of the target do-install
- Replace the use of ${CHMOD} 755 in Makefile
  with the use of @(,,755) in pkg-plist
Comment 1 Samy Mahmoudi 2018-08-17 16:57:47 UTC 
- Add option NLS
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2018-08-17 17:24:38 UTC 
testbuilds are fine, pending maintainer-ACK
Comment 3 Jimmy Olgeni freebsd_committer freebsd_triage 2018-08-17 17:43:16 UTC 
(In reply to Kurt Jaeger from comment #2)

I'm a bit AFK due to hospital stuff, so please go ahead. Thanks! \o/
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2018-08-17 18:06:46 UTC 
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-08-17 18:07:41 UTC 
A commit references this bug:

Author: pi
Date: Fri Aug 17 18:06:44 UTC 2018
New revision: 477439
URL: https://svnweb.freebsd.org/changeset/ports/477439

Log:
  x11-fm/rox-filer: add missing dependencies and clean Makefile

  - Regenerate patch files with make makepatch.
  - Remove useless assignment to DISTNAME.
  - Add a lib dependency on print/freetype2
  - Add a lib dependency on x11-fonts/fontconfig
  - Add LICENSE= GPLv2+
  - Move USES ahead of USE_*
  - Add gettext-runtime:build to the USES variable
  - Add ice to the variable USE_XORG and sort the corresponding list
  - Add cairo and gdkpixbuf2 to the variable USE_GNOME
  - Reindent the lines of the target post-configure
  - Split a line of the target do-install
  - Replace the use of ${CHMOD} 755 in Makefile
    with the use of @(,,755) in pkg-plist

  PR:		230710
  Submitted by:	Samy Mahmoudi <samy.mahmoudi@gmail.com>
  Approved by:	olgeni (maintainer)

Changes:
  head/x11-fm/rox-filer/Makefile
  head/x11-fm/rox-filer/files/patch-ROX-Filer_src_Makefile.in
  head/x11-fm/rox-filer/files/patch-ROX-Filer_src_configure
  head/x11-fm/rox-filer/pkg-plist
Comment 6 Samy Mahmoudi 2018-08-17 18:13:32 UTC 
(In reply to Jimmy Olgeni from comment #3)

Hello Jimmy,

I hope you will back at keyboard soon.

Peace.