Bug 230829 - [PATCH] net-p2p/gtk-gnutella: Do not call arc4random_stir
Summary: [PATCH] net-p2p/gtk-gnutella: Do not call arc4random_stir
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Xin LI
URL:
Keywords:
Depends on:
Blocks: 230756
  Show dependency tree / graph
 
Reported: 2018-08-23 04:47 UTC by Xin LI
Modified: 2018-08-26 08:14 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (woodsb02)

Attachments
Proposed patch (1.11 KB, patch)
2018-08-23 04:47 UTC, Xin LI 		no flags Details | Diff
Revised patch (2.01 KB, patch)
2018-08-25 19:54 UTC, Xin LI 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xin LI freebsd_committer freebsd_triage 2018-08-23 04:47:43 UTC 
Created attachment 196457 [details]
Proposed patch

arc4random_stir should not be called directly (it's fully automated after r227520, or approximately __FreeBSD_version 1000002), the interface will be removed soon (bug 230756).

Please upstream this patch.
Comment 1 Xin LI freebsd_committer freebsd_triage 2018-08-25 19:54:35 UTC 
Created attachment 196543 [details]
Revised patch
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-08-26 08:08:22 UTC 
A commit references this bug:

Author: delphij
Date: Sun Aug 26 08:07:30 UTC 2018
New revision: 478105
URL: https://svnweb.freebsd.org/changeset/ports/478105

Log:
  net-p2p/gtk-gnutella: Do not call arc4random_stir or arc4random_addrandom.

  PR:		230829, 230756
  Approved by:	portmgr (antoine)

Changes:
  head/net-p2p/gtk-gnutella/Makefile
  head/net-p2p/gtk-gnutella/files/
  head/net-p2p/gtk-gnutella/files/patch-src_lib_arc4random.c
  head/net-p2p/gtk-gnutella/files/patch-src_lib_random.c
Comment 3 Xin LI freebsd_committer freebsd_triage 2018-08-26 08:14:29 UTC 
Upstreamed at https://sourceforge.net/p/gtk-gnutella/bugs/548/ .