Bug 230834 - [PATCH] net/samba48: Do not use arc4random_stir
Summary: [PATCH] net/samba48: Do not use arc4random_stir
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Xin LI
URL:
Keywords:
Depends on: 230835
Blocks: 230756
  Show dependency treegraph
 
Reported: 2018-08-23 05:38 UTC by Xin LI
Modified: 2018-08-26 08:53 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (timur)


Attachments
Proposed patch (1.32 KB, patch)
2018-08-23 05:38 UTC, Xin LI
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xin LI freebsd_committer freebsd_triage 2018-08-23 05:38:16 UTC
Created attachment 196462 [details]
Proposed patch

arc4random_stir should not be used directly (it's fully automated after r227520, or approximately __FreeBSD_version 1000002), the interface will be removed soon (bug 230756).
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-08-26 08:47:07 UTC
A commit references this bug:

Author: delphij
Date: Sun Aug 26 08:46:30 UTC 2018
New revision: 478109
URL: https://svnweb.freebsd.org/changeset/ports/478109

Log:
  net/samba48: Do not use arc4random_stir.

  PR:		230834, 230756
  Approved by:	portmgr (antoine)

Changes:
  head/net/samba48/Makefile
  head/net/samba48/files/patch-source4__heimdal__lib__roken__rand.c
Comment 2 Xin LI freebsd_committer freebsd_triage 2018-08-26 08:48:44 UTC
The patch was done against the embedded version of heimdal; upstream heimdal bug was tracked at https://github.com/heimdal/heimdal/issues/401.