Bug 230895 - net/tcpreen: Fix build with Clang 6
Summary: net/tcpreen: Fix build with Clang 6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: http://beefy11.nyi.freebsd.org/data/h...
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-25 18:29 UTC by Tobias Kortkamp
Modified: 2018-09-09 07:19 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (jmohacsi)

Attachments
net__tcpreen.diff (1.28 KB, patch)
2018-08-25 18:29 UTC, Tobias Kortkamp 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-25 18:29:13 UTC 
The build fails with Clang 6 and soon the port will be marked as
BROKEN on 12.0 and 11.2 if we do not act.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-25 18:29:46 UTC 
Created attachment 196537 [details]
net__tcpreen.diff
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-09-09 07:19:19 UTC 
A commit references this bug:

Author: tobik
Date: Sun Sep  9 07:18:37 UTC 2018
New revision: 479276
URL: https://svnweb.freebsd.org/changeset/ports/479276

Log:
  net/tcpreen: Fix build with Clang 6

  main.cpp:111:27: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  "TCP re-engineering tool "VERSION" ("PACKAGE_HOST")\n"
                            ^

  http://beefy12.nyi.freebsd.org/data/head-amd64-default/p479076_s338486/logs/errors/tcpreen-1.4.4_3.log

  PR:		230895
  Submitted by:	tobik
  Approved by:	jmohacsi@bsd.hu (maintainer timeout, 2 weeks)

Changes:
  head/net/tcpreen/files/
  head/net/tcpreen/files/patch-src_main.cpp