Bug 230897 - net/linknx: Fix build with Clang 6
Summary: net/linknx: Fix build with Clang 6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: http://beefy11.nyi.freebsd.org/data/h...
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-25 18:53 UTC by Tobias Kortkamp
Modified: 2018-09-09 07:11 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (bkoenig)

Attachments
net__linknx.diff (1.76 KB, patch)
2018-08-25 18:53 UTC, Tobias Kortkamp 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-25 18:53:35 UTC 
The build fails with Clang 6 and soon the port will be marked as
BROKEN on 12.0 and 11.2 if we do not act.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-25 18:53:48 UTC 
Created attachment 196539 [details]
net__linknx.diff
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-09-09 07:11:06 UTC 
A commit references this bug:

Author: tobik
Date: Sun Sep  9 07:10:26 UTC 2018
New revision: 479273
URL: https://svnweb.freebsd.org/changeset/ports/479273

Log:
  net/linknx: Fix build with Clang 6

  objectcontroller.cpp:659:27: error: non-constant-expression cannot be narrowed from type 'int' to 'uint8_t' (aka 'unsigned char') in initializer list [-Wc++11-narrowing]
      uint8_t buf[2] = { 0, (isWrite ? 0x80 : 0x40) | (getBoolObjectValue() ? 1 : 0) };
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  http://beefy12.nyi.freebsd.org/data/head-amd64-default/p479076_s338486/logs/errors/linknx-0.0.1.32.log

  PR:		230897
  Submitted by:	tobik
  Approved by:	bkoenig@alpha-tierchen.de (maintainer timeout, 2 weeks)

Changes:
  head/net/linknx/Makefile
  head/net/linknx/files/patch-src_suncalc.cpp