Bug 230904 - net-im/centerim, net-im/centerim-devel: Fix build with Clang 6
Summary: net-im/centerim, net-im/centerim-devel: Fix build with Clang 6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: http://beefy11.nyi.freebsd.org/data/h...
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-26 05:25 UTC by Tobias Kortkamp
Modified: 2018-09-10 15:32 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (frank)

Attachments
net-im__centerim.diff (375 bytes, patch)
2018-08-26 05:26 UTC, Tobias Kortkamp 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-26 05:25:42 UTC 
The build fails with Clang 6 and soon the port will be marked as
BROKEN on 12.0 and 11.2 if we do not act.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-26 05:26:11 UTC 
Created attachment 196552 [details]
net-im__centerim.diff
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-26 05:27:46 UTC 
Comment on attachment 196552 [details]
net-im__centerim.diff

The error from the log is trivially patched, but there are later problems
then:

msnhook.cc:950:50: error: invalid operands to binary expression ('__bind<int &,
      sockaddr *, unsigned long>' and 'int')
    if(bind(s, (sockaddr *) &addr, sizeof(addr)) < 0 || listen(s, 1) < 0) {
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

I have given up afterwards.

It might be better to update CenterIM to the latest version instead.
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-26 05:32:26 UTC 
Should also be applicable to net-im/centerim-devel
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-09-10 15:32:43 UTC 
A commit references this bug:

Author: tobik
Date: Mon Sep 10 15:32:25 UTC 2018
New revision: 479433
URL: https://svnweb.freebsd.org/changeset/ports/479433

Log:
  net-im/centerim{,-devel}: Fix build with Clang 6

  In file included from rsshook.cc:32:
  ../../src/icqface.h:248:50: error: cannot combine with previous 'bool' declaration specifier
          bool findresults(const imsearchparams &sp, bool auto = false);
                                                          ^

  ... and more if one gets past this

  http://beefy12.nyi.freebsd.org/data/head-amd64-default/p479076_s338486/logs/errors/centerim-4.22.10_5.log
  http://beefy12.nyi.freebsd.org/data/head-amd64-default/p479076_s338486/logs/errors/centerim-devel-4.22.10.11_7.log

  PR:		230904
  Approved by:	frank@altpeter.de (maintainer timeout, 2 weeks)

Changes:
  head/net-im/centerim/Makefile
  head/net-im/centerim-devel/Makefile