Bug 230906 - devel/cld2: Fix build with Clang 6
Summary: devel/cld2: Fix build with Clang 6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Sivachenko
URL: http://beefy11.nyi.freebsd.org/data/h...
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-26 06:48 UTC by Tobias Kortkamp
Modified: 2018-08-27 17:11 UTC (History)
0 users

See Also:
demon: maintainer-feedback+


Attachments
devel__cld2.diff (399 bytes, patch)
2018-08-26 06:48 UTC, Tobias Kortkamp
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-26 06:48:43 UTC
The build fails with Clang 6 and soon the port will be marked as
BROKEN on 12.0 and 11.2 if we do not act.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-26 06:48:57 UTC
Created attachment 196555 [details]
devel__cld2.diff
Comment 2 Dmitry Sivachenko freebsd_committer freebsd_triage 2018-08-27 13:20:08 UTC
Thank you very much for your work.
Feel free to commit similar fixes to my ports without explicit approval.
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-27 17:10:33 UTC
Thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-08-27 17:11:22 UTC
A commit references this bug:

Author: tobik
Date: Mon Aug 27 17:10:22 UTC 2018
New revision: 478231
URL: https://svnweb.freebsd.org/changeset/ports/478231

Log:
  devel/cld2: Fix build with Clang 6

  cld_generated_cjk_uni_prop_80.cc:169:1: error: constant expression evaluates to -14 which cannot be narrowed to type 'CLD2::uint8' (aka 'unsigned char') [-Wc++11-narrowing]
  -14,-14,-14,-14,-14,-14,-14,-14, -14,-14,-14,-14,-14,-14,-14,-14,
  ^~~
  cld_generated_cjk_uni_prop_80.cc:169:1: note: insert an explicit cast to silence this issue
  -14,-14,-14,-14,-14,-14,-14,-14, -14,-14,-14,-14,-14,-14,-14,-14,
  ^~~
  static_cast<uint8>( )

  http://beefy11.nyi.freebsd.org/data/head-i386-default/p477696_s338122/logs/errors/cld2-20150505.log

  PR:		230906
  Submitted by:	tobik
  Approved by:	demon (maintainer)

Changes:
  head/devel/cld2/Makefile