Created attachment 196661 [details] [PATCH] dns/dhisd: update to 5.5 I also would like to adopt the port, so MAINTAINER info was changed.
Take.
(In reply to Koichiro Iwao from comment #1) thank you Koichiro, very appreciated. I am not quite sure if this one I should have pushed to any queue before - as I am still under mentorship process; added my mentors here to check/approve the commit before we go further. KR,
(In reply to Vinícius Zavam from comment #2) Oh, I didn't aware you've become ports committer. Welcome! Then, try it yourself. First of all, merge your bugzilla accounts. https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/bugzilla.html See you later on bugzilla as your FreeBSD.org account!
Hi, some comments: - Makefile: There is no NETBSD_PKGSRC (from PR 230989 which was rejected). - patch-Makefile: use CC=${CC} instead of hardcoding it to "clang" for GCC compatibility. - patch-Makefile: use PREFIX instead of hardcoding "/usr/local" in MYSQL_INCLUDE (yes, this is indeed part of the "old" patch) - patch-Makefile: better use WFLAGS+= (with a plus) instead of setting it unconditionally so that users can add their own warnings. But this might cause problems too (again old patch) - patch-Makefile: do not hardcode /usr/local in CFLAGS and LDFLAGS - pkg-descr: this file reads a bit as a change log, but could be fixed later (beat/araujo?)
'make check-sanity' and 'portlint -AC' look mostly fine.
Created attachment 198526 [details] use-local-distfiles Since upstream dist site is down right now, you can use local-distfiles instead using NetBSD CDN directly. You don't need to create new NETBSD_PKGSRC. https://www.freebsd.org/doc/en/books/porters-handbook/slow-sources.html I put the tarball in my local dist. Use LOCAL/meta instead. See attached patch.
thank you Koichiro, thank you René! I will work this all out, and should report back later on. very appreciated for all your time and concern here. KR,
Created attachment 198533 [details] [PATCH] dns/dhisd: update to 5.5, reviewed new version of the patch/diff, with updates and changes recommended by previous comments. also took care of 'pkg-descr'
Created attachment 198534 [details] [LOG] 11amd64
Created attachment 198535 [details] [LOG] 12amd64
Almost there, somehow files/dhisd.in now duplicates itself.
BTW, in most cases, you don't need to attach the build log if the build succeeded. That is a waste of a disk on the server. Just comment "build passed on (environment)" is enough. When I was a novice, I was also told the same :) If the build fails, it is worth to share the cause of failure.
thank you all for the feedback. appreciated! I will take of this last issue and should update the current patch asap. kr,
(In reply to Rene Ladan from comment #11) Hi René, I did run the tests again and did not get the issue regarding 'dhisd.in' you mentioned before. # diff 230990_my.diff ports_r482878_PATCH__dns_dhisd.diff # svn patch ports_r482878_PATCH__dns_dhisd.diff U dns/dhisd/Makefile U dns/dhisd/distinfo D dns/dhisd/files/INSTALL.bsd A dns/dhisd/files/dhisd.in D dns/dhisd/files/dhisd.sh D dns/dhisd/files/patch-INSTALL D dns/dhisd/files/patch-MODULES U dns/dhisd/files/patch-Makefile D dns/dhisd/files/patch-README D dns/dhisd/files/patch-dhisd.h D dns/dhisd/files/pkg-message.in U dns/dhisd/pkg-descr U dns/dhisd/pkg-plist # echo $? 0 # ls -1 dns/dhisd/files/ dhisd.in patch-Makefile also, my 'bulk -I' jail did not list a duplicated file. root@localhost:~ # ll /usr/local/etc/rc.d/ total 5 -r-xr-xr-x 1 root wheel 666 Nov 3 03:00 dhisd* maybe there was some old file there you tested from previous patch I sent? I also ran a 'revert' on my ports tree here before applying the patch.
I mean if you type `cat files/dhisd.in` you will see its contents twice.
Created attachment 198960 [details] [PATCH] dns/dhisd: update to 5.5, reviewed and fixed nice catch; updated the patch! I really have no idea how I missed that one. sorry though.
Approved for commit.
A commit references this bug: Author: egypcio Date: Mon Nov 12 09:15:39 UTC 2018 New revision: 484793 URL: https://svnweb.freebsd.org/changeset/ports/484793 Log: dns/dhisd: update to 5.5 * while here, adopt the port; * files/patch-Makefile; use CC=${CC} for clang and GCC compatibility; use PREFIX instead of hardcoding "/usr/local"; better use WFLAGS+= (with a plus). * also updated 'pkg-descr' with a longer description about the port. PR: 230990 Submitted by: egypcio Approved by: rene (mentor) Changes: head/dns/dhisd/Makefile head/dns/dhisd/distinfo head/dns/dhisd/files/INSTALL.bsd head/dns/dhisd/files/dhisd.in head/dns/dhisd/files/dhisd.sh head/dns/dhisd/files/patch-INSTALL head/dns/dhisd/files/patch-MODULES head/dns/dhisd/files/patch-Makefile head/dns/dhisd/files/patch-README head/dns/dhisd/files/patch-dhisd.h head/dns/dhisd/files/pkg-message.in head/dns/dhisd/pkg-descr head/dns/dhisd/pkg-plist