Created attachment 196694 [details] update to 1.3.14 This is a small update. 1.3.14 is the new stable version. The patch includes some unnecessary changes of file creation/modification time. If "make makepatch" can leave this part out during patch creation, it would reduce the size of the patch. Changelog: https://github.com/telegramdesktop/tdesktop/blob/dev/changelog.txt 1.3.14 (27.08.18) - Fix a crash in calls. 1.3.13 (25.08.18) - Export data from individual chats using the '...' menu. - Added a new night theme. - You can now assign custom themes as night and day themes to quickly switch between them. - Support for Telegram Passport 1.1 and improved password hashing algorithm to better protect Telegram Passport data.
Created attachment 196695 [details] poudriere log on 11.2-RELEASE-p2/amd64
I tried to build it on 11.1-RELEASE-p13/amd64, and it hits a compiler error (c++ segmentation fault). I'll take a look.
Created attachment 196796 [details] updated patch for 1.3.14 This patch works on both 11.1 and 11.2. For 11.1, clang60 is used. This does not add extra dependency, because the Xorg stuff already depends on llvm60.
Created attachment 196797 [details] poudriere log on 11.1-RELEASE-p13
A commit references this bug: Author: swills Date: Sun Sep 2 19:20:05 UTC 2018 New revision: 478814 URL: https://svnweb.freebsd.org/changeset/ports/478814 Log: net-im/telegram-desktop: update to 1.3.14 PR: 231014 Submitted by: Henry Hu <henry.hu.sh@gmail.com> (maintainer) Changes: head/net-im/telegram-desktop/Makefile head/net-im/telegram-desktop/distinfo head/net-im/telegram-desktop/files/gyp-patches head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_base_bytes.h head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_export_data_export__data__types.cpp head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_history_admin__log_history__admin__log__inner.cpp head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_VoIPController.cpp head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_audio_AudioInput.cpp head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_audio_AudioOutput.cpp head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_linux_AudioPulse.cpp head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_posix_NetworkSocketPosix.cpp head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_threading.h head/net-im/telegram-desktop/files/patch-Telegram_gyp_telegram__sources.txt
USES=compiler:c++17-lang sets the BUILD_DEPENDS, CC and CXX (as well as CPP) to what you have here in the 11.x case, and I think that's the right thing to do instead. Went ahead and committed with that, let me know if I missed something.
(In reply to Steve Wills from comment #6) Thanks. I think that your solution is better.
(In reply to Steve Wills from comment #6) I just noticed that you removed the BROKEN part. I think that it's still needed. As I said in the comments, this port not only requires C++17 compiler, but also C++17 runtime. Even with llvm60 or compiler:c++17-lang, C++17 runtime is still not present on 10.x. As a result, it cannot compile on 10.x Please restore that part. Thanks.
A commit references this bug: Author: swills Date: Wed Sep 5 16:14:38 UTC 2018 New revision: 479026 URL: https://svnweb.freebsd.org/changeset/ports/479026 Log: net-im/telegram-desktop: put back removed BROKEN line Can build but won't run on 10.x PR: 231014 Reported by: Henry Hu <henry.hu.sh@gmail.com> (maintainer) Pointyhat to: swills Changes: head/net-im/telegram-desktop/Makefile