Bug 231043 - archivers/urbackup-client: Fix database snapshot scripts and do port cleanup
Summary: archivers/urbackup-client: Fix database snapshot scripts and do port cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-31 00:55 UTC by freebsd
Modified: 2018-09-01 00:18 UTC (History)
1 user (show)

See Also:

Attachments
Ver2.2.6 Rev2 patch for urbackup-client (14.07 KB, patch)
2018-08-31 00:55 UTC, freebsd 		freebsd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description freebsd 2018-08-31 00:55:17 UTC 
Created attachment 196725 [details]
Ver2.2.6 Rev2 patch for urbackup-client

archivers/urbackup-client: Fix database snapshot scripts and do port cleanup

Port did not properly perform a substitution in the database snapshot scripts in %%PREFIX%%/share/urbackup/scripts during installation, leading to an error in the logs and an inability to use the backup scripts.

* Addresses database script substitution error
* Port cleanup:
  - Regenerate patches using "make makepatch" to silence portlint
  - Remove unneeded dependency on gettext
  - Patch Makefile.am to address errors leading to the distribution's "install" target failing. As a result, use the distribution's "install" target, rather than performing installation in port's Makefile, greatly simplifying the port's Makefile.

portlint: OK (looks fine)
testport: OK (poudriere: 111i386, 111amd64, 112amd64)

NOTE: Since the initial 2.2.6 update I have been getting emails from pkg-fallout@freebsd.org regarding failed builds due to automake being missing. I could only intermittently reproduce this error, both using 'poudriere testport' and in my own ports tree. In my ports tree, if I encountered the error a 'make clean' would resolve it (i.e., the next build would succeed). In many test builds of the current patch I have not encountered this error. The error seems to have gone away after regenerating the patches using "make makepatch" rather than using "svn diff".
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-09-01 00:17:14 UTC 
A commit references this bug:

Author: swills
Date: Sat Sep  1 00:17:09 UTC 2018
New revision: 478639
URL: https://svnweb.freebsd.org/changeset/ports/478639

Log:
  archivers/urbackup-client: Fix database snapshot scripts and do port cleanup

  PR:		231043
  Submitted by:	freebsd@coombscloud.com (maintainer)

Changes:
  head/archivers/urbackup-client/Makefile
  head/archivers/urbackup-client/files/patch-Makefile.am
  head/archivers/urbackup-client/files/patch-client_ConfigPath.cpp
  head/archivers/urbackup-client/files/patch-client_stringtools.cpp
  head/archivers/urbackup-client/files/patch-client_stringtools.h
  head/archivers/urbackup-client/pkg-plist
Comment 2 Steve Wills freebsd_committer freebsd_triage 2018-09-01 00:18:41 UTC 
Committed, thanks!