A normal make results in an error that slang.h can not be found and if aalib-1.4.0 is a downstream dependency on another build then we see : . . . cc -DHAVE_CONFIG_H -I. -I. -I. -O2 -pipe -fstack-protector -fno-strict-aliasing -I/usr/local/include/slang -c aalinux.c -o aalinux.o >/dev/null 2>&1 --- aaslang.lo --- *** [aaslang.lo] Error code 1 make[7]: stopped in /usr/ports/graphics/aalib/work/aalib-1.4.0/src --- aalinux.lo --- mv -f .libs/aalinux.lo aalinux.lo --- aafastre.lo --- cc -DHAVE_CONFIG_H -I. -I. -I. -O2 -pipe -fstack-protector -fno-strict-aliasing -I/usr/local/include/slang -c aafastre.c -o aafastre.o >/dev/null 2>&1 --- aafont.lo --- mv -f .libs/aafont.lo aafont.lo --- aafastre.lo --- mv -f .libs/aafastre.lo aafastre.lo --- aamktabl.lo --- mv -f .libs/aamktabl.lo aamktabl.lo 1 error make[7]: stopped in /usr/ports/graphics/aalib/work/aalib-1.4.0/src *** [all-recursive] Error code 1 make[6]: stopped in /usr/ports/graphics/aalib/work/aalib-1.4.0 1 error make[6]: stopped in /usr/ports/graphics/aalib/work/aalib-1.4.0 ===> Compilation failed unexpectedly. Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to the maintainer. *** Error code 1 Stop. make[5]: stopped in /usr/ports/graphics/aalib *** Error code 1 Stop. make[4]: stopped in /usr/ports/graphics/aalib *** Error code 1 Stop. make[3]: stopped in /usr/ports/devel/sdl12 *** Error code 1 Stop. make[2]: stopped in /usr/ports/devel/sdl12 *** Error code 1 Stop. make[1]: stopped in /usr/ports/emulators/virtualbox-ose *** Error code 1 Stop. The real truth is that slang.h can not be found. a manual check revelas this and so I edit the Makefile and change the CFLAGS line to insert -I/usr/local/include before -I/usr/local/include/slang and then all goes well.
Testing on my local 12-current machine and in poudriere, no issue
(In reply to Nathan from comment #1) which depends on aalib that fails?
Confirmed
Created attachment 196817 [details] Add cflags
(In reply to Nathan from comment #4) > Created attachment 196817 [details] > Add cflags This is not correct. There's hidden dependency on slang which should be fixed properly.
Created attachment 196819 [details] Patch How's this? - Add options for all available drivers including slang and allow them to be enabled independently. This also fixes hidden dependency on slang which makes the port fail to build in presence of devel/libslang2 - Switch to USES=localbase, options helpers, fix license, other minor fixes
(In reply to Dmitry Marakasov from comment #6) If no one gets to it before I do when I get home and can I’ll work on it. At work atm
(In reply to Nathan from comment #7) > (In reply to Dmitry Marakasov from comment #6) > If no one gets to it before I do when I get home and can I’ll work on it. At > work atm Not sure what you mean by work here - the patch is complete and tested. I'm asking for review/additional testing and I'm going to commit it if there are no objections.
(In reply to Dmitry Marakasov from comment #8) Ah didn’t see ya made a patch. My bad
(In reply to Dmitry Marakasov from comment #8) Tested and built with me
I can not reproduce this either. titan# stat -x /usr/ports/UPDATING File: "/usr/ports/UPDATING" Size: 534019 FileType: Regular File Mode: (0644/-rw-r--r--) Uid: ( 0/ root) Gid: ( 0/ wheel) Device: 246,763887817 Inode: 19 Links: 1 Access: Sun Sep 2 04:20:17 2018 Modify: Thu Jun 21 23:07:50 2018 Change: Sun Sep 2 04:20:17 2018 titan# Now the process blows up elsewhere .. hence bugid 231125
A commit references this bug: Author: amdmi3 Date: Tue Sep 4 12:37:13 UTC 2018 New revision: 478952 URL: https://svnweb.freebsd.org/changeset/ports/478952 Log: - Fix license - Switch to USES=localbase - Fix hidden dependency on devel/libslang2 [1] - Add separate option for each supported driver (X11, NCURSES, SLANG) - Sort plist PR: 231044 [1] Reported by: dclarke@blastwave.org [1] Changes: head/graphics/aalib/Makefile head/graphics/aalib/pkg-plist