Bug 231090 - security/py-paramiko: Update to 2.4.1
Summary: security/py-paramiko: Update to 2.4.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-02 11:02 UTC by Kai Knoblich
Modified: 2018-09-30 14:42 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (sbz)


Attachments
py-paramiko-2.4.1.patch (1.93 KB, patch)
2018-09-02 11:02 UTC, Kai Knoblich
kai: maintainer-approval? (sbz)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2018-09-02 11:02:13 UTC
Created attachment 196784 [details]
py-paramiko-2.4.1.patch

Hello,

attached is the patch that updates security/py-paramiko to 2.4.1.

Changes by upstream:
- https://github.com/paramiko/paramiko/compare/2.4.0...2.4.1

Changes to the port:
- changed USES?= to USES=
- removed option EXAMPLES as there are no more examples that are installed.
- removed concurrent keyword from USE_PYTHON
- added NO_ARCH
- added dependencies for test target


QA:
~~~
- poudriere (10.4-, 11.1-, 11.2-RELEASE, 12.0-ALPHA4 i386 + amd64) for each py27 + py36 flavor -> OK
- portlint -> OK

Results from make test:

For py27:
> Ran 149 tests in 15.723s
> 
> FAILED (errors=7)
> *** Error code 1

For py36:
> Ran 149 tests in 7.311s
>
> FAILED (errors=9)
> *** Error code 1

Better test results can be yielded with the Python package "pytest-relaxed" (not in the ports tree at the moment) and using ${PREFIX}/bin/pytest instead of ${PYTHON_CMD} -m unittest :

> 3 failed, 212 passed, 11 skipped in 98.67 seconds

The three remaining errors are there because the file 'tests/test_rsa.key.pub' is missing from the tar-ball but it exits in the repository at GH.

Another problem is, that the Python package pytest-relaxed works only with devel/py-pytest > 3 AND < 3.3 officially due some regression with newer versions.

Thus I have not yet created a PR to add the Python package 'pytest-relaxed' to the ports tree.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-09-30 14:42:35 UTC
A commit references this bug:

Author: miwi
Date: Sun Sep 30 14:41:40 UTC 2018
New revision: 480958
URL: https://svnweb.freebsd.org/changeset/ports/480958

Log:
  - Update to 2.4.1
  - Removed option EXAMPLES as there are no more examples that are installed.
  - Removed concurrent keyword from USE_PYTHON
  - Added NO_ARCH
  - Added dependencies for test target

  Changes by upstream:
  - https://github.com/paramiko/paramiko/compare/2.4.0...2.4.1

  PR:		231090
  Submitted by:	freebsd_ports@k-worx.org
  Approved by:	maintainer timeout
  Sponsored by:	iXsystems Inc.

Changes:
  head/security/py-paramiko/Makefile
  head/security/py-paramiko/distinfo