Bug 231506 - audio/wmmp: abide CFLAGS
Summary: audio/wmmp: abide CFLAGS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-20 09:50 UTC by Piotr Kubaj
Modified: 2018-10-30 12:22 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (beastieboy)

Attachments
patch (998 bytes, patch)
2018-09-20 09:50 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-09-20 09:50:36 UTC 
Created attachment 197266 [details]
patch

CMakeLists.txt adds -Oz to CFLAGS. This breaks compilation with base GCC and potentially overwrites -O2 (default for ports).

This patch fixes it.

Tested on powerpc64 and amd64.
Comment 1 Nathan 2018-09-20 15:19:18 UTC 
Confirming this does eliminate the 0z flag and builds with -O2 flags
Comment 2 Nicolas Herry 2018-09-23 20:45:15 UTC 
Looks very good, thank you! Should be able to test that in the next few days.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-10-28 13:51:32 UTC 
A commit references this bug:

Author: linimon
Date: Sun Oct 28 13:50:41 UTC 2018
New revision: 483294
URL: https://svnweb.freebsd.org/changeset/ports/483294

Log:
  Honor CFLAGS.

  PR:		231506
  Submitted by:	Piotr Kubaj
  Approved by:	maintainer

Changes:
  head/audio/wmmp/files/
  head/audio/wmmp/files/patch-CMakeLists.txt