Bug 231607 - graphics/libdrm: update to 2.4.96
Summary: graphics/libdrm: update to 2.4.96
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL: https://cgit.freedesktop.org/mesa/drm...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-09-22 20:04 UTC by voidanix
Modified: 2018-11-27 21:30 UTC (History)
1 user (show)

See Also:
zeising: maintainer-feedback+


Attachments
graphics/libdrm: update to 2.4.94 (903 bytes, patch)
2018-09-22 20:04 UTC, voidanix
no flags Details | Diff
update graphics/libdrm to 2.4.96 (12.37 KB, patch)
2018-10-18 19:49 UTC, Niclas Zeising
no flags Details | Diff
update (12.43 KB, patch)
2018-11-15 21:31 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description voidanix 2018-09-22 20:04:27 UTC
Created attachment 197372 [details]
graphics/libdrm: update to 2.4.94
Comment 1 Niclas Zeising freebsd_committer freebsd_triage 2018-09-22 21:29:13 UTC
I have not seen a release announcement for this yet.
Comment 2 voidanix 2018-09-23 09:25:33 UTC
(In reply to Niclas Zeising from comment #1)

I found the announcement here: https://www.spinics.net/lists/dri-devel/msg187010.html
Comment 3 Niclas Zeising freebsd_committer freebsd_triage 2018-09-24 15:40:50 UTC
Thank you!
I wasn't aware that libdrm had stopped announcing on xorg-announce (perhaps someone just missed to mail that list).

There seem to be some discussions upstream about the release.  I need to walk through it before I update the port in FreeBSD.
Comment 4 Niclas Zeising freebsd_committer freebsd_triage 2018-10-18 19:49:48 UTC
Created attachment 198320 [details]
update graphics/libdrm to 2.4.96

Hi!
I've updated libdrm to 2.4.96 in our development repo.  You can find it here:
https://github.com/FreeBSDDesktop/freebsd-ports/tree/feature/libdrm

I have also attached a patch from the git repo above that should apply to a ports tree checked out with svn.

Can you please give it a test run?

There was some upstream changes, so I had to re-roll some of our local patches.  I think I got it right, but a test run before commit would be helpful.
Comment 5 Jan Beich freebsd_committer freebsd_triage 2018-10-19 12:38:55 UTC
Comment on attachment 198320 [details]
update graphics/libdrm to 2.4.96

> --    if (maj != DRM_MAJOR || !S_ISCHR(sbuf.st_mode))
> +-    if (!drmNodeIsDRM(maj, min) || !S_ISCHR(sbuf.st_mode))
>  +    if (DRM_MAJOR && maj != DRM_MAJOR || !S_ISCHR(sbuf.st_mode))

Ugh, don't do rebases blindly. Move bug 217585 fix inside drmNodeIsDRM() instead of reverting upstream change[1].

[1] https://cgit.freedesktop.org/mesa/drm/commit/?id=f8392583418a
Comment 6 Jan Beich freebsd_committer freebsd_triage 2018-11-15 21:31:46 UTC
Created attachment 199260 [details]
update

Feedback timeout.
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-11-27 21:26:10 UTC
A commit references this bug:

Author: zeising
Date: Tue Nov 27 21:25:22 UTC 2018
New revision: 486065
URL: https://svnweb.freebsd.org/changeset/ports/486065

Log:
  graphics/libdrm: Update to 2.4.96

  Rework local patches a bit because of upstream changes.

  Changelog:
  https://lists.freedesktop.org/archives/dri-devel/2018-August/187286.html
  https://lists.x.org/archives/xorg-announce/2018-October/002920.html
  https://lists.x.org/archives/xorg-announce/2018-October/002925.html

  PR:		231607
  Submitted by:	voidanix (original version)
  Obtained from:	https://github.com/FreeBSDDesktop/freebsd-ports/tree/feature/libdrm

Changes:
  head/graphics/libdrm/Makefile
  head/graphics/libdrm/distinfo
  head/graphics/libdrm/files/patch-xf86drm.c
  head/graphics/libdrm/files/patch-xf86drmMode.c
  head/graphics/libdrm/pkg-plist
Comment 8 Niclas Zeising freebsd_committer freebsd_triage 2018-11-27 21:30:47 UTC
Committed, thanks!