Bug 231632 - sysutils/tuptime: update to 3.4.0
Summary: sysutils/tuptime: update to 3.4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-23 16:18 UTC by Ricardo Fraile
Modified: 2018-09-25 16:26 UTC (History)
3 users (show)

See Also:
jeremy: maintainer-feedback+

Attachments
Patch with the changes to apply over current Tuptime port 3.3.3 (3.30 KB, patch)
2018-09-23 16:18 UTC, Ricardo Fraile 		no flags Details | Diff
Patched updated - Remove 'MANPAGES=' and update pkg-message (4.04 KB, patch)
2018-09-24 09:10 UTC, Ricardo Fraile 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ricardo Fraile 2018-09-23 16:18:06 UTC 
Created attachment 197398 [details]
Patch with the changes to apply over current Tuptime port 3.3.3

Hi,


Tuptime have a new release (3.4.0) and it would be good to have it on FreeBSD.

Withit the update, apart of some fixes, there is some work to improve the BSD compatibility.

Please, see the attached patch.



Thanks,
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2018-09-23 17:44:29 UTC 
Take
Comment 2 Nathan 2018-09-23 23:29:13 UTC 
Comment on attachment 197398 [details]
Patch with the changes to apply over current Tuptime port 3.3.3

+MANPAGES=	tuptime.1
Looks as it's not used? If not, remove

I would have also used 
OPTIONS_DEFINE= EXAMPLES

do-install-EXAMPLES-on:
         @${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
         ${INSTALL_SCRIPT} ${WRKSRC}/scripts/db-tuptime-migrate.sh {STAGEDIR}${EXAMPLESDIR}/db-tuptime-migrate.sh
-	${INSTALL_SCRIPT} ${WRKSRC}/scripts/db-tuptime-migrate-3.0-to-3.1.sh ${STAGEDIR}${EXAMPLESDIR}/db-tuptime-migrate-3.0

and remove them from do-install
Comment 3 Ricardo Fraile 2018-09-24 09:10:31 UTC 
Created attachment 197426 [details]
Patched updated - Remove 'MANPAGES=' and update pkg-message

Hi,

As recommended, I remove the 'MANPAGES=' line. Also, the pkg-message is updated. Please, see tuptime-3.4.0-v2.diff


Thanks,
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2018-09-24 16:22:51 UTC 
(In reply to Ricardo Fraile from comment #3)
Thank you for the update.

It builds fine in {10.4,11.2}{amd64,i386} and 12i386. Also seems to run fine in 10.4amd64.

Awaiting maintainer approval/timeout.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-09-25 16:26:10 UTC 
A commit references this bug:

Author: fernape
Date: Tue Sep 25 16:25:44 UTC 2018
New revision: 480685
URL: https://svnweb.freebsd.org/changeset/ports/480685

Log:
  sysutils/tuptime: update to 3.4.0

  PR:	231632
  Submitted by:	rfraile@rfraile.eu
  Approved by:	tcberner (mentor, implicit), jeremy@smart-serv.net (maintainer)

Changes:
  head/sysutils/tuptime/Makefile
  head/sysutils/tuptime/distinfo
  head/sysutils/tuptime/files/pkg-message.in
  head/sysutils/tuptime/files/tuptime.in
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2018-09-25 16:26:41 UTC 
Committed with minor changes,

Thanks!