Bug 231739 - [NEW PORT] security/py-bro-pkg: Bro NSM package manager
Summary: [NEW PORT] security/py-bro-pkg: Bro NSM package manager
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on: 231738
Blocks:
  Show dependency treegraph
 
Reported: 2018-09-26 13:30 UTC by Shirkdog
Modified: 2018-10-09 13:54 UTC (History)
2 users (show)

See Also:


Attachments
[NEW PORT] security/py-bro-pkg: Bro NSM package manager (3.02 KB, patch)
2018-09-26 13:30 UTC, Shirkdog
no flags Details | Diff
[NEW PORT] security/py-bro-pkg: Bro NSM package manager (3.26 KB, patch)
2018-09-26 23:09 UTC, Shirkdog
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shirkdog 2018-09-26 13:30:46 UTC
Created attachment 197516 [details]
[NEW PORT] security/py-bro-pkg: Bro NSM package manager

Port for the Bro NSM Package Manager to manage content for Bro NSM. This port depends on py-btest to build.
Comment 1 Nathan 2018-09-26 22:34:58 UTC
Comment on attachment 197516 [details]
[NEW PORT] security/py-bro-pkg: Bro NSM package manager

+PORTREVISION=	1
Remove 

BSD3CLAUSE and first line of RUN_DEPENDS is not aligned the same, nor is python in USES=

GH_TUPLE 
Remove :cc21207 and add DISTVERSIONPREFIX=    v
under PORTNAME 
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex3
Comment 2 Shirkdog 2018-09-26 23:09:46 UTC
Created attachment 197536 [details]
[NEW PORT] security/py-bro-pkg: Bro NSM package manager

Wow, I had to make a lot of fixes to this. I incorporated your requests, and I updated distinfo as the "v" prefix changed the filename. This worked in my testing.
Comment 3 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-09-29 20:44:03 UTC
I'll try to commit this port as well.

BTW, it would be nice if you could submit your patches as shell archives (shars) or SVN diffs. Patch files generated with Git does not integrate nicely with patch(1) and SVN repositories (or maybe I am missing something). Related chapter in the Porter's Handbook: https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-submitting 

Cheers :)
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-09-29 21:06:26 UTC
Revision URL: https://reviews.freebsd.org/D17358
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-10-09 13:52:01 UTC
A commit references this bug:

Author: 0mp
Date: Tue Oct  9 13:51:41 UTC 2018
New revision: 481633
URL: https://svnweb.freebsd.org/changeset/ports/481633

Log:
  New port: security/py-bro-pkg: Bro NSM package manager

  The Bro Package Manager makes it easy for Bro users to install
  and manage third party scripts as well as plugins for Bro and
  BroControl. The command-line tool is preconfigured scripts as
  well as plugins for Bro and BroControl. The command-line tool
  is preconfigured to download packages from the Bro package source,
  a GitHub repository that has been setup such that any developer
  can request their Bro package be included. See the README file
  of that repository for information regarding the package submission
  process. NOTE: It's left up to users to decide for themselves
  via code review, GitHub comments/stars, or other metrics whether
  any given package is trustworthy as there is no implied guarantees
  that it's secure just because it's been accepted into the default
  package source. See the package manager documentation for further
  usage information, how-to guides, and walkthroughs. For offline
  reading, it's also available in the doc/ directory of the
  source code distribution.

  WWW: https://github.com/bro/package-manager/

  PR:		231739
  Submitted by:	Shirkdog <mshirk@daemon-security.com>
  Reviewed by:	Nathan <ndowens@yahoo.com>
  Approved by:	krion (mentor)
  Differential Revision:	https://reviews.freebsd.org/D17358

Changes:
  head/security/Makefile
  head/security/py-bro-pkg/
  head/security/py-bro-pkg/Makefile
  head/security/py-bro-pkg/distinfo
  head/security/py-bro-pkg/pkg-descr
  head/security/py-bro-pkg/pkg-message
Comment 6 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-10-09 13:54:41 UTC
Committed!