Created attachment 197728 [details] [patch] update devel/cctz to 2.2 Attached patch updates devel/cctz to 2.1 QA: portlint ok poudriere testport ok (10/amd64)
Comment on attachment 197728 [details] [patch] update devel/cctz to 2.2 Remove PORTREVISION since portversion is being updated GH_ACCOUNT should stay where it was to retain correct order of variables
(In reply to Nathan from comment #1) Just put a space between uses and GH section like: USES USE_GITHUB GH_ACCOUNT
Created attachment 197752 [details] [patch] update devel/cctz to 2.2 [v2] patch v2: Remove PORTREVISION Order GH_ACCOUNT per PHB guidelines in 15.8
(In reply to Nathan from comment #2) I see no guidelines suggesting extra blank lines after USES. The sample Makefile in the PHB (Ch 14) doesn't indicate that. Avoiding the extra line seems like a good balance since it would not really improve readability or consistency - and as a bonus, avoids excessive proliferation of vertical spacing. I fixed the GH_ACCOUNT ordering per reasonable documented grouping guidelines. And also fixed the stray PORTREVISION. Thanks.
(In reply to John Hein from comment #4) Reason I said space is because portlint complains
A commit references this bug: Author: swills Date: Sun Oct 7 04:23:59 UTC 2018 New revision: 481413 URL: https://svnweb.freebsd.org/changeset/ports/481413 Log: devel/cctz: update to 2.2 PR: 231896 Submitted by: John Hein <z7dr6ut7gs@snkmail.com> (maintainer) Changes: head/devel/cctz/Makefile head/devel/cctz/distinfo
Committed, thanks!