Bug 231934 - graphics/dspdfviewer: Fails to build on FreeBSD 11.2-RELEASE-p4
Summary: graphics/dspdfviewer: Fails to build on FreeBSD 11.2-RELEASE-p4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-04 07:23 UTC by Santhosh Raju
Modified: 2018-11-27 01:37 UTC (History)
0 users

See Also:
santhosh.raju: merge-quarterly?


Attachments
Fix for dspdfviewer build failure. (628 bytes, patch)
2018-10-04 07:23 UTC, Santhosh Raju
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Santhosh Raju 2018-10-04 07:23:34 UTC
Created attachment 197769 [details]
Fix for dspdfviewer build failure.

The change in clang version has caused -Wredundant-parens to be considered as error causing the builds to fail.

I have changed the ${OSVERSION} variable to apply -Wno-error=redundant-parens to the list of CFLAGS from 1102000 and onwards.

A patch has been attached along with this to fix this issue.

It would be nice if the patch can be applied to the ports tree of FreeBSD.

Thank you
Santhosh
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-10-07 04:48:25 UTC
A commit references this bug:

Author: swills
Date: Sun Oct  7 04:48:09 UTC 2018
New revision: 481419
URL: https://svnweb.freebsd.org/changeset/ports/481419

Log:
  graphics/dspdfviewer: Fix build on 11.2

  PR:		231934
  Submitted by:	Santhosh Raju <santhosh.raju@gmail.com> (maintainer)

Changes:
  head/graphics/dspdfviewer/Makefile
Comment 2 Steve Wills freebsd_committer freebsd_triage 2018-10-07 04:49:10 UTC
Committed, thanks!
Comment 3 Santhosh Raju 2018-11-09 07:56:27 UTC
Since the fix was committed to HEAD after the quarterly branch was cut, the builds in the quarterly branch still continues to fail.

Would it be possible to merge this change into the quarterly branch?

I have put up the appropriate flag in the Re-Opened ticket.

Thank you
Santhosh
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-11-27 01:35:56 UTC
A commit references this bug:

Author: swills
Date: Tue Nov 27 01:35:45 UTC 2018
New revision: 485974
URL: https://svnweb.freebsd.org/changeset/ports/485974

Log:
  MFH: r481419

  graphics/dspdfviewer: Fix build on 11.2

  PR:		231934
  Submitted by:	Santhosh Raju <santhosh.raju@gmail.com> (maintainer)
  Approved by:	ports-secteam (implicit)

Changes:
_U  branches/2018Q4/
  branches/2018Q4/graphics/dspdfviewer/Makefile