Bug 231976 - sysutils/qdirstat: fix build on GCC-based architectures
Summary: sysutils/qdirstat: fix build on GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kevin Bowling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-05 11:52 UTC by Piotr Kubaj
Modified: 2018-10-08 23:23 UTC (History)
2 users (show)

See Also:
kbowling: maintainer-feedback+


Attachments
patch (426 bytes, patch)
2018-10-05 11:52 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-05 11:52:09 UTC
Created attachment 197811 [details]
patch

This port tries to set -std=gnu++11 which fails on architectures that use GCC in base. Fix it by requiring C++11-compatible compiler.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Kevin Bowling freebsd_committer freebsd_triage 2018-10-06 19:16:59 UTC
Looks good to me although I separately wonder if qt5 USES needs this centralized to start with and then on to root cause of getting all of ports to use modern gcc on ppc64

Do you have a bit to commit this patch or would you like me to?
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-06 19:23:21 UTC
(In reply to Kevin Bowling from comment #1)
It probably needs this centralized, but since I'm not a Qt5 expert, I'm just sending patches for everything that fails in Poudriere build. I'm not sure if some Qt5-related ports built without any patches, though.

For now I want to get all the build failures fixed, since that also helps powerpc, powerpcspe, sparc64 and mips* (when it gets GCC from ports).

I don't have a commit bit, otherwise I'd just commit it :)
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-10-08 23:21:53 UTC
A commit references this bug:

Author: kbowling
Date: Mon Oct  8 23:21:10 UTC 2018
New revision: 481578
URL: https://svnweb.freebsd.org/changeset/ports/481578

Log:
  sysutils/qdirstat: fix build on GCC-based architectures

  PR:		231976
  Submitted by:	Piotr Kubaj
  Approved by:	timur (mentor)
  Differential Revision:	https://reviews.freebsd.org/D17463

Changes:
  head/sysutils/qdirstat/Makefile
Comment 4 Kevin Bowling freebsd_committer freebsd_triage 2018-10-08 23:23:03 UTC
Committed, thanks!