Bug 232052 - sysutils/s6 update to 2.7.2.1 bug-fixes
Summary: sysutils/s6 update to 2.7.2.1 bug-fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mateusz Piotrowski
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-10-07 21:37 UTC by dewayne
Modified: 2018-10-15 16:19 UTC (History)
2 users (show)

See Also:
crest: maintainer-feedback+


Attachments
Patch to update s6 to version 2.7.2.1 (1.09 KB, patch)
2018-10-15 15:23 UTC, crest
no flags Details | Diff
Update s6 to 2.7.2.1 and make portlint happy (1.45 KB, patch)
2018-10-15 15:50 UTC, crest
crest: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dewayne 2018-10-07 21:37:17 UTC
Would it be possible to update the ports for s6 to 2.7.2.1.  bug-fixes are always welcome :)
Comment 1 crest 2018-10-15 15:23:59 UTC
Created attachment 198179 [details]
Patch to update s6 to version 2.7.2.1

A straight forward patch updating s6 to version 2.7.2.1. Withholding maintainer approval until I tested it in my next poudriere bulk runs.
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-10-15 15:41:10 UTC
I'll commit it once you confirm that it is ready.
Comment 3 crest 2018-10-15 15:50:23 UTC
Created attachment 198181 [details]
Update s6 to 2.7.2.1 and make portlint happy

I tested s6 2.7.2.1 and made small changes to make portlint happy (start the comment with a capital letter, remove the dot at the the comment, add SUB_* of from the USES section).

Please commit this patch.
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-10-15 16:03:48 UTC
Differential revision: https://reviews.freebsd.org/D17568

Thanks! I also moved USE_LDCONFIG to the USE* section.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-10-15 16:12:18 UTC
A commit references this bug:

Author: 0mp
Date: Mon Oct 15 16:11:58 UTC 2018
New revision: 482158
URL: https://svnweb.freebsd.org/changeset/ports/482158

Log:
  sysutils/s6: Update to 2.7.2.1

  While here, pet portlint:
  - Fix COMMENT
  - Fix order of variables

  Changelog:
  http://git.skarnet.org/cgi-bin/cgit.cgi/s6/tree/NEWS

  PR:		232052
  Submitted by:	crest@rlwinm.de (maintainer)
  Reported by:	dewayne@heuristicsystems.com.au
  Reviewed by:	krion
  Approved by:	krion (mentor)
  Differential Revision:	https://reviews.freebsd.org/D17568

Changes:
  head/sysutils/s6/Makefile
  head/sysutils/s6/distinfo
  head/sysutils/s6/pkg-plist
Comment 6 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-10-15 16:19:36 UTC
Committed! Thank you!