Bug 232066 - graphics/gimp-app: installation failed due error in plist file
Summary: graphics/gimp-app: installation failed due error in plist file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-08 11:26 UTC by bsd
Modified: 2018-10-29 11:39 UTC (History)
11 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
gimp app plist fix (886 bytes, patch)
2018-10-08 12:34 UTC, Sergey Akhmatov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description bsd 2018-10-08 11:26:14 UTC
Trying to install port ends with following:

====> Compressing man pages (compress-man)
===>>> Starting check for runtime dependencies
===>>> Gathering dependency list for graphics/gimp-app from ports

===>>> The dependency for graphics/jpeg-turbo
       seems to be handled by jpeg-8_7

===>>> Dependency check complete for graphics/gimp-app

===>>> py27-gimp-2.8.22_1 >> graphics/gimp-app (2/3)

===>  Installing for gimp-app-2.10.6,1
===>  Checking if gimp-app already installed
===>   Registering installation for gimp-app-2.10.6,1 as automatic
pkg-static: Plist error, directory listed as a file: libexec/gimp/2.2/plug-ins/help-browser
*** Error code 74

Stop.
make[1]: stopped in /usr/ports/graphics/gimp-app
*** Error code 1

Stop.
make: stopped in /usr/ports/graphics/gimp-app

So everything up to stage phase is OK, pkg_static complains when trying to install. I looked into plist file, and, indeed, it is there.

With one-line patch pplied, installation succeeds:

--- pkg-plist.orig	2018-10-08 06:32:43.553649000 +0200
+++ pkg-plist	2018-10-08 13:22:16.934845000 +0200
@@ -370,7 +370,7 @@
 libexec/gimp/2.2/plug-ins/grid/grid
 libexec/gimp/2.2/plug-ins/guillotine/guillotine
 libexec/gimp/2.2/plug-ins/help/help
-%%HELPBROWSER%%libexec/gimp/2.2/plug-ins/help-browser
+%%HELPBROWSER%%libexec/gimp/2.2/plug-ins/help-browser/help-browser
 libexec/gimp/2.2/plug-ins/hot/hot
 libexec/gimp/2.2/plug-ins/ifs-compose/ifs-compose
 libexec/gimp/2.2/plug-ins/imagemap/imagemap
Comment 1 Sergey Akhmatov 2018-10-08 12:34:00 UTC
Created attachment 197910 [details]
gimp app plist fix

I've hit the same bug today with HELPBROWSER option enabled.
While testing the fix with poudriere testport I've detected one more problem - orphanted file:
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: libexec/gimp/2.2/plug-ins/help-browser/help-browser
Error: Orphaned: libexec/gimp/2.2/plug-ins/web-page/web-page
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: libexec/gimp/2.2/plug-ins/help-browser
===> Error: Plist issues found.

The attached patch fixes them both.
Comment 2 O. Hartmann 2018-10-08 16:43:53 UTC
Ran into the same problem, also, the port doens't build with poudriere. Thats brings up the question, how the port update have made it into the tree without a test which is required from all of us offering patches/ports and so on ...
Comment 3 rkoberman 2018-10-08 20:16:47 UTC
I can confirm both the problem (affects many) and the fix.
Comment 4 Trond Endrestøl 2018-10-09 16:40:52 UTC
I tried the patch and the port compiles, etc, but I got this error when extracting the package generated by synth:

# pkg update --repository Synth && pkg upgrade --repository Synth
...
[6/13] Upgrading gimp-app from 2.8.22_1,1 to 2.10.6,1...
[6/13] Extracting gimp-app-2.10.6,1:   6%
pkg: Fail to create temporary file: /usr/local/libexec/gimp/2.2/plug-ins/align-layers/.align-layers.4kg29BPGas23:Not a directory
[6/13] Extracting gimp-app-2.10.6,1: 100%

/usr/local/libexec/gimp/2.2/plug-ins/align-layers exists and is an "old" executable:

-rwxr-xr-x  1 root  wheel  17584 Mar  1  2018 /usr/local/libexec/gimp/2.2/plug-ins/align-layers

In-place upgrade seems out of the question, so I resolved this issue by deleting the graphics/gimp-app package, and installing it and the other missing packages from my package repo. So far, so good.
Comment 5 Marko Cupać 2018-10-11 09:04:04 UTC
I have also encountered problem with in-place upgrade. The port was built in poudriere without problems. But `pkg upgrade' failed:

[65/97] Extracting gimp-app-2.10.6,1:   6%
pkg: Fail to create temporary file: /usr/local/libexec/gimp/2.2/plug-ins/align-layers/.align-layers.gH7sHdrKY6NR:Not a directory

Thanks to above comment, I uninstalled gimp-app, which in turn uninstalled a few more packages:

Installed packages to be REMOVED:
	gimp-app-2.8.22_1,1
	py27-gimp-2.8.22_1
	gimp-gutenprint-5.2.14
	gimp-2.8.22,2

Number of packages to be removed: 4

After this, `sudo pkg install gimp' installed latest versions of above packages without problems.
Comment 6 lumiwa 2018-10-13 16:22:21 UTC
(In reply to Marko Cupać from comment #5)
Does Help (F1) works on your system, please?

On mine FreeBSD 11.2-RELEASE (amd64) not:

Could not open 'https://docs.gimp.org/2.10/en/gimp-help.xml' for reading: Operation not supported

Perhaps you are missing GIO backends and need to install GVFS?

Thank you.
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-10-14 17:14:50 UTC
A commit references this bug:

Author: kwm
Date: Sun Oct 14 17:14:34 UTC 2018
New revision: 482098
URL: https://svnweb.freebsd.org/changeset/ports/482098

Log:
  gimp-app:
  Depend on glib-networking [2], which is used for https connection.
  Fix plist when default-off options are enabled [1].
  While here overhaul dependancies.

  py-gimp:
  Fix a issue with unresolved symbols in the python library, due to incorrect linking.

  PR:		232066 [1], 232047 [2]
  Reported by:	bsd@dino.sk [1], rsmith@xs4all.nl [2]

Changes:
  head/graphics/gimp-app/Makefile
  head/graphics/gimp-app/files/patch-plug-ins_pygimp_Makefile.in
  head/graphics/gimp-app/pkg-plist
  head/graphics/py-gimp/Makefile
Comment 8 Koop Mast freebsd_committer freebsd_triage 2018-10-14 17:23:04 UTC
Thanks for the reports.
Comment 9 Marko Cupać 2018-10-15 08:47:50 UTC
(In reply to lumiwa from comment #6)

Hi,

my F1 doesn't work by choice, as I'm building gimp without HELP by means of setting graphics_gimp_UNSET = HELP in make.conf.

Thank you for tip though.
Comment 10 Lapo Luchini 2018-10-29 10:06:14 UTC
Still happens with `pkg upgrade` to gimp-app-2.10.6_1,1:

Fail to create temporary file: /usr/local/libexec/gimp/2.2/plug-ins/align-layers