Bug 232143 - security/dropbear is not broken with cbc only needs ctr to function
Summary: security/dropbear is not broken with cbc only needs ctr to function
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-10 02:30 UTC by dewayne
Modified: 2018-11-09 19:43 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (pkubaj)


Attachments
patch to add CBC_IMPLIES (528 bytes, patch)
2018-10-11 01:58 UTC, Steve Wills
pkubaj: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dewayne 2018-10-10 02:30:50 UTC
This line in the Makefile is incorrect
CBC_BROKEN= ./session.h:77:3: error: unknown type name 'symmetric_CBC'

CBC functions correctly iff CTR is also selected.  

This is what I use and suggest
     CBC=on: Use CBC mode for ciphers (less secure) requires CTR
     CTR=on: Use CTR mode for ciphers (more secure)

Which I have running on FreeBSD11.1 and 11.2Stable i386 and amd64 servers.
Comment 1 Steve Wills freebsd_committer freebsd_triage 2018-10-11 01:58:23 UTC
Created attachment 198027 [details]
patch to add CBC_IMPLIES

Perhaps this will do the trick?
Comment 2 dewayne 2018-10-11 03:08:14 UTC
Comment on attachment 198027 [details]
patch to add CBC_IMPLIES

Thank-you it does.  Though I have a bit of a thing about, behind the scenes selection.  I wouldn't rule out "some noddy" wanting CBC without CTR, perhaps in an effort to limit dropbear's size.  Would it be possible to append to the CBC_DESC, ie (implies CTR). :)
Comment 3 Steve Wills freebsd_committer freebsd_triage 2018-10-11 15:30:55 UTC
(In reply to dewayne from comment #2)
Will do. Need approval from maintainer tho, or to wait for the timeout.
Comment 4 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-13 20:15:48 UTC
I know about this issue, but I didn't have time to take care of it since I was busy with other things (related to FreeBSD ports as well), sorry.

Anyway, this patch is good to go.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-11-09 19:43:14 UTC
A commit references this bug:

Author: swills
Date: Fri Nov  9 19:42:12 UTC 2018
New revision: 484543
URL: https://svnweb.freebsd.org/changeset/ports/484543

Log:
  security/dropbear: fix CBC option

  PR:		232143
  Reported by:	dewayne@heuristicsystems.com.au
  Approved by:	Piotr Kubaj <pkubaj@anongoth.pl> (maintainer)

Changes:
  head/security/dropbear/Makefile
Comment 6 Steve Wills freebsd_committer freebsd_triage 2018-11-09 19:43:36 UTC
Committed, thanks!