Bug 232787 - [MAINTAINER] sysutils/py-pyznap update to 1.1.0
Summary: [MAINTAINER] sysutils/py-pyznap update to 1.1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2018-10-29 17:07 UTC by Dries Michiels
Modified: 2018-11-02 13:11 UTC (History)
1 user (show)

See Also:

Attachments
update to 1.1.0 (4.58 KB, patch)
2018-10-29 17:07 UTC, Dries Michiels 		driesm: maintainer-approval+
Details | Diff
update to 1.1.0 (2.15 KB, patch)
2018-10-29 17:12 UTC, Dries Michiels 		no flags Details | Diff
update to 1.1.0 (2.20 KB, patch)
2018-10-29 17:36 UTC, Dries Michiels 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dries Michiels freebsd_committer freebsd_triage 2018-10-29 17:07:57 UTC 
Created attachment 198739 [details]
update to 1.1.0
Comment 1 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-10-29 17:09:53 UTC 
Hi, is it possible that the patch file is broken? You seem to patch the Makefile twice.
Comment 2 Dries Michiels freebsd_committer freebsd_triage 2018-10-29 17:12:14 UTC 
Created attachment 198740 [details]
update to 1.1.0
Comment 3 Dries Michiels freebsd_committer freebsd_triage 2018-10-29 17:13:09 UTC 
Good catch, should be fixed now. I had Makefile.orig and Makefile.back in the same dir. Probably because of that :D!
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-10-29 17:23:46 UTC 
(In reply to Dries Michiels from comment #3)

BTW, is there a release changelog for v1.1.0?
Comment 5 Dries Michiels freebsd_committer freebsd_triage 2018-10-29 17:27:17 UTC 
Changes for 1.1.0 release include:

Added:
- pyznap now uses pv to show progress of zfs send operations.
- Better error handling during zfs send over ssh.

Fixed
- Changed readme to only mention python 3.5+.
Comment 6 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-10-29 17:32:47 UTC 
(In reply to Dries Michiels from comment #5)

Oh, shouldn't we add pv to runtime dependencies in this case?
Comment 7 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-10-29 17:33:40 UTC 
https://reviews.freebsd.org/D17753
Comment 8 Dries Michiels freebsd_committer freebsd_triage 2018-10-29 17:36:10 UTC 
Created attachment 198741 [details]
update to 1.1.0

Add pv as run depend to display progress.

This patch updates the tool to the latest version and adds a missing run depend for full functionality (pv). Also add concurrent to USE_PYTHON
Comment 9 Dries Michiels freebsd_committer freebsd_triage 2018-10-29 17:49:59 UTC 
(In reply to Mateusz Piotrowski from comment #6)
Yep I would say that is the way to go. 
pv only takes+-50kB as extra dependency.
Comment 10 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-11-01 12:06:20 UTC 
(In reply to Dries Michiels from comment #9)

Alright, let's test it.
Comment 11 commit-hook freebsd_committer freebsd_triage 2018-11-02 13:05:59 UTC 
A commit references this bug:

Author: 0mp
Date: Fri Nov  2 13:05:26 UTC 2018
New revision: 483804
URL: https://svnweb.freebsd.org/changeset/ports/483804

Log:
  sysutils/py-pyznap: Update to v1.1.0

  Changelog:
  - pyznap now uses pv to show progress of zfs send operations.
  - Better error handling during zfs send over ssh.

  PR:		232787
  Submitted by:	Dries Michiels <driesm.michiels@gmail.com> (maintainer)
  Reviewed by:	krion
  Approved by:	krion (mentor)
  Differential Revision:	https://reviews.freebsd.org/D17753

Changes:
  head/sysutils/py-pyznap/Makefile
  head/sysutils/py-pyznap/distinfo
  head/sysutils/py-pyznap/files/pkg-message.in
Comment 12 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-11-02 13:11:29 UTC 
Committed! Thank you! :)