Created attachment 198771 [details] net-mgmt/prometheus2: Remove syslog config files This patch removes the syslog and newsyslog config files for now for a few reasons. - I'd originally intended them to be examples that a user could take and use if they wanted to redirect Prometheus syslog entries to their own log files, however, they were turned into @sample entries during commit. - Without a reload of syslogd, simply placing the config files will do nothing and no instructions were included in pkg-message saying that the user should reload syslogd. - I am currently unsure if the package should be changing the users syslog config (although, after the @sample change, they did have to request it via the SYSLOG option) - If they do request it, how to reload the syslog so that the config file is used right away? Basically, I have far too many questions surrounding the feature now, so I'm removing it entirely until I have considered it further and spoken with some other porters on how they have handled syslog related things. I may add them back as examples again in the future with a suitable pkg-message about their existance. With this change, Prometheus will still sends its output to syslog, but without specific configuration the messages will be routed according to however the user has already configured their syslogd. This patch should also fix #232706, as there will be no syslog configs to be copying around anymore.
Comment on attachment 198771 [details] net-mgmt/prometheus2: Remove syslog config files Approving my own diff
A commit references this bug: Author: swills Date: Wed Oct 31 01:44:04 UTC 2018 New revision: 483541 URL: https://svnweb.freebsd.org/changeset/ports/483541 Log: net-mgmt/prometheus2: Remove syslog and newsyslog config files While here, pet portlint PR: 232813 Submitted by: David O'Rourke <dor.bsd@xm0.uk> (maintainer) Changes: head/net-mgmt/prometheus2/Makefile head/net-mgmt/prometheus2/files/newsyslog.conf.in head/net-mgmt/prometheus2/files/syslog.d.conf.in head/net-mgmt/prometheus2/pkg-plist
Committed, thanks!
> Without a reload of syslogd, simply placing the config files will do nothing newsyslog(8) does load configuration when it changes because it is started on schedule by crontab(1). For syslogd(8) this is true that it doesn't reload its configs, but this is rather a problem than the right behavior. I suggested to fix this: big#232838