Bug 232859 - graphics/gauche-gl: respect CFLAGS
Summary: graphics/gauche-gl: respect CFLAGS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-31 17:12 UTC by Piotr Kubaj
Modified: 2018-12-06 13:51 UTC (History)
1 user (show)

See Also:

Attachments
patch (1.35 KB, patch)
2018-10-31 17:12 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-31 17:12:29 UTC 
Created attachment 198811 [details]
patch

This port doesn't respect CFLAGS, which also causes build failure on GCC architectures, since c99 needs to be used, but GCC uses c89 by default.

While here, add USES=gl.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2018-11-01 14:11:24 UTC 
I'm getting:

math3d-lib.c:2351: error: 'for' loop initial declaration used outside C99 mode
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2018-11-24 08:16:17 UTC 
ping?
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2018-11-28 00:16:54 UTC 
(In reply to Mark Linimon from comment #2)
pong

I don't have this problem, it builds with my patch.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-12-06 13:51:15 UTC 
A commit references this bug:

Author: linimon
Date: Thu Dec  6 13:51:07 UTC 2018
New revision: 486757
URL: https://svnweb.freebsd.org/changeset/ports/486757

Log:
  Add patch to respect CFLAGS.  This fixes the build on powerpc64.

  While here, add gl to USES, per modern usage.

  PR:		232859
  Submitted by:	Piotr Kubaj

Changes:
  head/graphics/gauche-gl/Makefile
  head/graphics/gauche-gl/files/
  head/graphics/gauche-gl/files/patch-src_Makefile.in