Bug 232885 - lang/retro12: update to 2018.8
Summary: lang/retro12: update to 2018.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL: https://forthworks.com/retro/changes.txt
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-01 13:35 UTC by Walter Schwarzenfeld
Modified: 2018-11-23 10:53 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (0mp)

Attachments
svn-diff-retro12-2018.8 (1.06 KB, patch)
2018-11-01 13:35 UTC, Walter Schwarzenfeld 		no flags Details | Diff
alternate-diff-rename-ri (3.52 KB, patch)
2018-11-01 14:35 UTC, Walter Schwarzenfeld 		no flags Details | Diff
svn-diff-rename-ri_v2 (3.52 KB, patch)
2018-11-01 14:43 UTC, Walter Schwarzenfeld 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Walter Schwarzenfeld freebsd_triage 2018-11-01 13:35:23 UTC 
Created attachment 198855 [details]
svn-diff-retro12-2018.8

ChangeLog in READ.md. Portlint ok.
Comment 1 Walter Schwarzenfeld freebsd_triage 2018-11-01 14:35:49 UTC 
Created attachment 198857 [details]
alternate-diff-rename-ri

Alternate patch to rename /usr/local/bin/ri to /usr/local/bin/ri12
Comment 2 Walter Schwarzenfeld freebsd_triage 2018-11-01 14:43:01 UTC 
Created attachment 198858 [details]
svn-diff-rename-ri_v2

Was an error in it.
Comment 3 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-11-01 23:04:12 UTC 
Upstream developer told me that the program names are going to be changed next release to make it easier for the users to install this package alongside Ruby, etc.

I'll test the patch soon. Thank you for the submission. It is greatly appreciated!
Comment 4 Walter Schwarzenfeld freebsd_triage 2018-11-03 00:23:43 UTC 
https://forthworks.com/retro/changes.txt:

=== 2018-11-02 ===
15:29:24 [370fe0f616] *CURRENT* begin work on renaming binaries to avoid naming conflicts (user: crc tags: trunk)
Comment 5 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-11-04 00:24:50 UTC 
https://reviews.freebsd.org/D17830

I think I'll leave the names of the interpreters as they are now and wait for the next release. 

Thank you for the patch! I modified it a little bit:
- Use USES=shebangfix instead of REINPLACE_CMD.
- Use PREFIX instead of LOCALBASE to refer to the directory prefix where the port is going to install its software.
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-11-23 10:53:23 UTC 
A commit references this bug:

Author: 0mp
Date: Fri Nov 23 10:52:23 UTC 2018
New revision: 485650
URL: https://svnweb.freebsd.org/changeset/ports/485650

Log:
  lang/retro12: Update to 2018.8

  Also:
  - Fix the order of variables.
  - Set USES=shebangfix for the rre interpreter.

  PR:		232885
  Submitted by:	w.schwarzenfeld@utanet.at
  Reviewed by:	krion, mat ndowens_yahoo.com
  Approved by:	mat (mentor)
  Differential Revision:	https://reviews.freebsd.org/D17830

Changes:
  head/lang/retro12/Makefile
  head/lang/retro12/distinfo
Comment 7 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-11-23 10:53:59 UTC 
Committed! Thanks!