Bug 233201 - net-p2p/namecoin: Update to 0.17.0
Summary: net-p2p/namecoin: Update to 0.17.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Koichiro Iwao
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2018-11-13 15:15 UTC by Chad Jacob Milios
Modified: 2018-11-26 02:22 UTC (History)
4 users (show)

See Also:
milios: maintainer-feedback+

Attachments
svn diff from /usr/ports (2.65 KB, patch)
2018-11-13 15:15 UTC, Chad Jacob Milios 		milios: maintainer-approval+
Details | Diff
namecoin-qt5 (4.26 KB, text/plain)
2018-11-19 09:20 UTC, Koichiro Iwao 		meta: maintainer-approval+
Details
svn diff from /usr/ports (3.62 KB, patch)
2018-11-25 19:00 UTC, Chad Jacob Milios 		milios: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chad Jacob Milios 2018-11-13 15:15:58 UTC 
Created attachment 199209 [details]
svn diff from /usr/ports

tested on 11.2/amd64
Comment 1 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-17 15:15:22 UTC 
Take.
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2018-11-17 15:24:31 UTC 
Comment on attachment 199209 [details]
svn diff from /usr/ports

+	${INSTALL} ${FILESDIR}/namecoin-qt.desktop \
+		${STAGEDIR}${PREFIX}/share/applications/

This should use ${INSTALL_DATA} so that it gets the right permissions.
Comment 3 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-18 04:33:38 UTC 
testbuild@12amd64 fails due to dependent port fails.
net/qt4-network is required but it doesn't build with OpenSSL 1.1.x.
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-19 09:20:10 UTC 
Created attachment 199334 [details]
namecoin-qt5

Switched to QT5. What about this?
Comment 5 Chad Jacob Milios 2018-11-20 12:24:39 UTC 
Comment on attachment 199334 [details]
namecoin-qt5

the COMMENT?= was because COMMENT is already set differently by the slave ports. beside that this is perfect. thanks
Comment 6 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-20 13:31:07 UTC 
(In reply to Chad Jacob Milios from comment #5)
Okay, sorry about that. I'll chaenge it back.
Comment 7 Chad Jacob Milios 2018-11-25 19:00:23 UTC 
Created attachment 199553 [details]
svn diff from /usr/ports

incorporates switch from QT4 to QT5
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-11-26 02:05:33 UTC 
A commit references this bug:

Author: meta
Date: Mon Nov 26 02:04:58 UTC 2018
New revision: 485911
URL: https://svnweb.freebsd.org/changeset/ports/485911

Log:
  net-p2p/namecoin: Update to 0.17.0

  Also, switched to Qt5 because net/qt4-network is required by dependency
  however it fails to build with OpenSSL 1.1.1. FreeBSD base OpenSSL has been
  switched to 1.1.1 since FreeBSD 12.

  PR:		233201
  Submitted by:	Chad Jacob Milios <milios@ccsys.com> (maintainer)
  Approved by:	mentors (implicit)

Changes:
  head/net-p2p/namecoin/Makefile
  head/net-p2p/namecoin/distinfo
  head/net-p2p/namecoin/files/namecoin-qt.desktop
Comment 9 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-26 02:22:51 UTC 
Committed, thanks! Sorry for making you wait.