Bug 233214 - graphics/librsvg2: "PORTREVISON" typo
Summary: graphics/librsvg2: "PORTREVISON" typo
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kubilay Kocak
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2018-11-14 01:51 UTC by John Hein
Modified: 2019-01-07 11:11 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)
koobs: merge-quarterly-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2018-11-14 01:51:13 UTC
When graphics/librsvg2 was updated to 2.40.20 (May 2018), there was a stray assignment PORTREVISON=1.  That's a typo (SON instead of SION).  But it did not need PORTREVISION set to 1 anyway.  So it's harmless.

But next time this is updated (latest upstream version is 2.44), please remove the bogus PORTREVISON line.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-11-14 03:56:57 UTC
A commit references this bug:

Author: koobs
Date: Wed Nov 14 03:56:42 UTC 2018
New revision: 484912
URL: https://svnweb.freebsd.org/changeset/ports/484912

Log:
  graphics/librsvg2: Remove PORTREVISON (typo) variable

  ports r470310 updated graphics/librsvg2 (PORTVERSION) to 2.40.20, but also
  included a typo'd PORTREVISION variable, with a value of 1, in the change.

  Since the PORTVERSION was updated, incrementing the PORTREVISION was not
  necessary as the updated package would have been built without it.

  Since the typo'd variable is not included in PKGNAME version calculation,
  it is a noop.

  Remove the variable accordingly.

  PR:		233214
  Reported by:	John Hein <z7dr6ut7gs snkmail com>
  Approved by:	portmgr (just fix it)
  MFH:		2018Q4

Changes:
  head/graphics/librsvg2/Makefile
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-01-07 11:11:26 UTC
Missed merge window, ports r484912 now exists in quarterly