Created attachment 199376 [details] qpdfview patch My patch fixes some problems issued by portlint and poudriere and improves options management. - Adds USE_GL= gl and USES+= gl, as required by poudriere. - Adds a line before QMAKE_SOURCE_PATH to separate it from the USE block, as required by portlint. - Adds QT4_USE+= qt+=corelib and QT5_USE+= qt+=core,dbus,gui,widgets, as required by poudriere. (I am unsure the syntax I used in this changelog would be correct, but the one I used in the Makefile surely is: I just added the needed words where they were needed.) - Moves the DJVU and PS option from OPTIONS_MULTI_BACKEND to OPTIONS_DEFINE, because they should be both optional, but the BACKEND construction requires that at least one of them be selected. (I think BACKEND was introduced to put the nice title "Additional documents support" over the two options, but because of the unwanted side effect it should be removed.) - Makes QT5 default instead of QT4, because it is more recent. (I use qpdfview with QT5 almost everyday since months: it works perfectly.) Everything has been tested on poudriere 11.2-RELEASE amd64/i386.
I forgot a change: - Adds DJVU as default option, because I think it is better to have one more feature in package instead of one less.
Created attachment 199384 [details] qpdfview patch with PORTREVISION increased I increased PORTREVISION, as I think the USES flags modification require it, and maybe the change in default port options too.
Created attachment 200529 [details] print/qpdfview: update to 0.4.18beta1 and Makefile cleanup - Update to 0.4.18.b1 - Modify Makefile to make poudriere and portlint happy - Some make options cleanup Thanks to Lorenzo Salvadore.
QA looks fine for me.
A commit references this bug: Author: meta Date: Wed Feb 6 01:18:48 UTC 2019 New revision: 492285 URL: https://svnweb.freebsd.org/changeset/ports/492285 Log: print/qpdfview: Update to 0.4.18.b1 While here, - Make portlint happy - Some make options cleanup - Remove Qt4 conditional deprecation as Qt4 support has already been dropped at r487596 PR: 233352 Submitted by: Marco Beishuizen <mbeis@xs4all.nl> (maintainer) Lorenzo Salvadore <phascolarctos@protonmail.ch> (initial version) Changes: head/print/qpdfview/Makefile head/print/qpdfview/distinfo head/print/qpdfview/pkg-plist
Comitted with minor changes. Removed following block as Qt4 support has already been dropped at r487596. .if ${PORT_OPTIONS:MQT4} DEPRECATED= Qt4 has been EOL since december 2015 EXPIRATION_DATE= 2019-03-15 .endif Thank you for your contribution.