Bug 234179 - science/py-dlib: fix build with GCC-based architectures
Summary: science/py-dlib: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Gleb Popov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-19 19:39 UTC by Piotr Kubaj
Modified: 2018-12-22 01:19 UTC (History)
2 users (show)

See Also:
arrowd: maintainer-feedback+

Attachments
patch (1.21 KB, patch)
2018-12-19 19:39 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-12-19 19:39:54 UTC 
Created attachment 200283 [details]
patch

This port needs new GCC to build, so add USES=compiler:c++11-lang to fix build on GCC architectures.

Additionally, it tests for AVX support even if AVX option is off, which breaks build.

Explicitly disable AVX when AVX option is off. Since avxargs is used by BLASLAPACK option, rename their avxags to blaslapackargs.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Gleb Popov freebsd_committer freebsd_triage 2018-12-20 07:05:37 UTC 
The change looks fine, thanks for fixing that.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-12-22 01:19:20 UTC 
A commit references this bug:

Author: linimon
Date: Sat Dec 22 01:18:32 UTC 2018
New revision: 488038
URL: https://svnweb.freebsd.org/changeset/ports/488038

Log:
  This port needs a newer GCC to build, so add USES=compiler:c++11-lang
  to fix build on GCC-based architectures.

  Additionally, it tests for AVX support even if AVX option is off,
  which breaks the build.

  Explicitly disable AVX when AVX option is off.  Since avxargs is used
  by BLASLAPACK option, rename their avxags to blaslapackargs.

  While here, pet portlint (whitespace).

  PR:		234179
  Submitted by:	Piotr Kubaj
  Approved by:	maintainer

Changes:
  head/science/py-dlib/Makefile