Bug 234225 - audio/baresip: Add OPTION for PulseAudio support
Summary: audio/baresip: Add OPTION for PulseAudio support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Romain Tartière
URL:
Keywords: feature
Depends on:
Blocks:
 
Reported: 2018-12-20 17:37 UTC by Romain Tartière
Modified: 2018-12-21 01:55 UTC (History)
1 user (show)

See Also:
crees: maintainer-feedback+

Attachments
Patch to add pulseaudio option (1.47 KB, patch)
2018-12-20 17:37 UTC, Romain Tartière 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Tartière freebsd_committer freebsd_triage 2018-12-20 17:37:41 UTC 
Created attachment 200312 [details]
Patch to add pulseaudio option

Dear maintainer,

Baresip can be built with PulseAudio support but the port does not currently permits this.

The attached patch enable this as an option (disabled by default, so that package is not changed and PORTREVISION does not need bumping).
Comment 1 Chris Rees freebsd_committer freebsd_triage 2018-12-20 17:52:28 UTC 
If that's what you really want to use, I won't stand in your way :)

Please go ahead.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-12-20 17:58:40 UTC 
A commit references this bug:

Author: romain
Date: Thu Dec 20 17:58:02 UTC 2018
New revision: 487895
URL: https://svnweb.freebsd.org/changeset/ports/487895

Log:
  Add an option to enable PulseAudio

  The option is disabled by default, so the package is not modified, no
  PORTREVISION bump needed.

  PR:		234225
  Approved by:	crees (maintainer)

Changes:
  head/audio/baresip/Makefile
  head/audio/baresip/Makefile.depends
Comment 3 Romain Tartière freebsd_committer freebsd_triage 2018-12-20 17:59:12 UTC 
Great!

Done, thanks
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-21 01:55:40 UTC 
Assign to committer that resolved