Bug 234260 - audio/hydrogen: Update to latest commit and switch to Qt 5
Summary: audio/hydrogen: Update to latest commit and switch to Qt 5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-22 02:42 UTC by Shane
Modified: 2018-12-25 08:32 UTC (History)
1 user (show)

See Also:
FreeBSD: maintainer-feedback+


Attachments
maintainer update for audio/hydrogen (27.78 KB, patch)
2018-12-22 02:42 UTC, Shane
koobs: maintainer-approval-
Details | Diff
maintainer update for audio/hydrogen (28.43 KB, patch)
2018-12-25 00:52 UTC, Shane
FreeBSD: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shane 2018-12-22 02:42:25 UTC
Created attachment 200347 [details]
maintainer update for audio/hydrogen

Update audio/hydrogen to 1.0.0-beta1 so we can move from qt4 to qt5
The hydrogen project is very slow in making releases, so use a recent commit in master to include fixes made throughout the year after qt5 support was added.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-12-22 03:46:33 UTC
Please keep compiler:c++11-lang!  It partially reverts ports r459300
for no reason and will probably break the build on powerpc64 again.

+/usr/share/pixmaps/h2-icon.svg
+@dir /usr/share/pixmaps

Something is wrong...

+DISTVERSION=	1.0.0.b1
+GH_TAGNAME=	538eaeb9f4e9 # master at 8/10

Please use git describe --tags to derive a proper version here:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex5

-do-test-TEST-on:
+do-test:

Why this change?  Is src/tests/tests also available when the port
is compiled with TEST=off?

+USE_QT=	qmake buildtools core gui linguisttools network widgets xml xmlpatterns

Are qt5-buildtools, qt5-linguisttools, qt5-qmake really run
dependencies of Hydrogen?  Maybe something like this would be better:

USE_QT=	core gui network widgets xml xmlpatterns buildtools_build linguisttools_build qmake_build

Please confirm that this passes a Poudriere test build.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-22 09:14:41 UTC
Comment on attachment 200347 [details]
maintainer update for audio/hydrogen

This patch needs an update
Comment 3 Shane 2018-12-25 00:52:59 UTC
Created attachment 200479 [details]
maintainer update for audio/hydrogen

Sorry, seem to have been a bit lazy on this one.

There is H2_UNIX_ICON_PATH but setting it wouldn't work for me so I patched the CMakeLists.txt
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2018-12-25 06:58:18 UTC
Thanks, looks ok to me.  Two changes I made:

- There is no need to run gtk-update-icon-cache when using Qt, so
  INSTALLS_ICONS is not needed here.  It is only needed for Gtk
  applications (see [1]).
- DISTVERSION was incorrectly set.  Please take a second look at
  the example in the handbook.

[1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/using-gnome.html#using-gnome-variables
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-12-25 06:59:07 UTC
A commit references this bug:

Author: tobik
Date: Tue Dec 25 06:58:14 UTC 2018
New revision: 488293
URL: https://svnweb.freebsd.org/changeset/ports/488293

Log:
  audio/hydrogen: Update to latest commit and switch to Qt 5

  PR:		234260
  Submitted by:	maintainer

Changes:
  head/audio/hydrogen/Makefile
  head/audio/hydrogen/distinfo
  head/audio/hydrogen/files/patch-CMakeLists.txt
  head/audio/hydrogen/files/patch-src_cli_CMakeLists.txt
  head/audio/hydrogen/files/patch-src_gui_CMakeLists.txt
  head/audio/hydrogen/files/patch-src_player_CMakeLists.txt
  head/audio/hydrogen/files/patch-src_synth_CMakeLists.txt
  head/audio/hydrogen/pkg-plist
Comment 6 Shane 2018-12-25 08:28:48 UTC
(In reply to Tobias Kortkamp from comment #4)

I run xfce4, after moving the icon into share/icons/... the applications menu only shows the icon when INSTALLS_ICONS is set during install. While the app is qt it seems anyone using a gtk desktop will need it set, while I expect a kde desktop would not.