Assume maintainership, and fix minor nits.
Created attachment 200378 [details] py-pid.diff
Thank you for offering to take maintainership of a port Mattias I note that - pid's sdist provides a LICENSE_FILE. Could you add that to the patch please - pid has test command support. could you add TEST_DEPENDS (nosse) and a (do-)test target, the following should work: @cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test Upstream has incorrectly added nose as a setup_requires not a tests_require. Could you patch setup.py accordingly and report it upstream please.
Created attachment 200559 [details] py-pid.diff Thanks for the fast reply Kubilay! Ok so this new patch adds LICENSE_FILE, and adds a patch file that removes setup_requires entirely. As far as I can see, the source package on pypi does not include the actual tests directory, so as I understand it, it is not possible to run any tests as it stands now, therefore there is unfortunately no do-test target. I may open a pull request to the upstream repo to fix the tests_require, and add tests to their MANIFEST.in. But I hope that this can be committed as is for now, since I do not know how long the upstream PR will take, and it will require a new release from them. Let me know if I misunderstood anything or if I should make any other changes =)
(In reply to Mattias Lindvall from comment #3) Sorry, I think I made a mistake with the ticket flags. I intended to change the maintainer-feedback from ? to + to indicate that I responded. Did not intend to set the maintainer-approval. Not sure how that would work when maintainer is ports@FreeBSD.org.
(In reply to Kubilay Kocak from comment #2) I see that you set needs-qa. Let me say that I have tried running various make commands such as build, package, install, deinstall. And portlint -C looks fine.
A commit references this bug: Author: swills Date: Sun Jan 6 01:11:33 UTC 2019 New revision: 489427 URL: https://svnweb.freebsd.org/changeset/ports/489427 Log: devel/py-pid: Assign maintainer, fix minor issues PR: 234283 Submitted by: Mattias Lindvall <mattias.lindvall@gmail.com> Changes: head/devel/py-pid/Makefile head/devel/py-pid/files/ head/devel/py-pid/files/patch-setup.py head/devel/py-pid/pkg-descr
Committed, thanks!