Created attachment 200519 [details] Proposed patch (since 480741 revision) Patch to update games/oolite port from 1.86 to 1.88 version. Look following links for changes: https://github.com/OoliteProject/oolite/releases/tag/1.88 https://github.com/OoliteProject/oolite/blob/1.88/Doc/CHANGELOG.TXT http://aegidian.org/bb/viewtopic.php?f=1&t=19927 - Add gl to USES - Replace %%DATADIR%% to ${DATADIR} for PLIST_FILES variable - Remove unneeded patch for deps/mozilla/js/src/shell/jsworkers.cpp.rej, because there is no such file for extracted archive - Remove patch for deps/mozilla/js/src/configure.in, because generated configure file used instead - Fix configure error for aarch64 by replacing "-O" with "-O2" compiler flag for MOZ_OPTIMIZE_FLAGS variable in deps/mozilla/js/src/configure file. Remove related BROKEN_aarch64 variable.
Comment on attachment 200519 [details] Proposed patch (since 480741 revision) Approved by: portmgr (unmaintained port) Pending QA
Created attachment 200520 [details] Proposed patch (since 480741 revision) According to GCC compiler documentation, the alternative name for "-O" is "-O1" for compiler option: https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html#Optimize-Options Probably, possible to use "-O1" instead of "-O2", if needed. I just used some default value in ports for amd64 architecture, which returned by `make -C /usr/ports -V CFLAGS` command. The "-O" and "-O2" compiler options are used in /usr/src/share/mk/sys.mk file, based on different conditions, for example: https://github.com/freebsd/freebsd/blob/5c861640127b95aa6b29327a48da153695e84c10/share/mk/sys.mk#L164-L177 Also possible, that message in BROKEN_aarch64 variable is outdated and there is no need for related changes for deps/mozilla/js/src/configure file, after OBJC_CLANG_VERSION=60 in ports r480741. As I understood, the "-O" compiler flag is used to build deps/mozilla/js/src/shell/js.cpp file: https://github.com/OoliteProject/spidermonkey-ff4/blob/ca2fb5423fab4d72a3dc5fec911ce20bda01f223/js/src/shell/js.cpp So, I decided to remove related changes from the patch. I guess, someone just need to check support for "-O" compiler option for aarch64 architecture, otherwise possible to propose patch to change this value for deps/mozilla/js/src/configure file.
A commit references this bug: Author: swills Date: Wed Dec 26 20:36:59 UTC 2018 New revision: 488434 URL: https://svnweb.freebsd.org/changeset/ports/488434 Log: games/oolite: Update to 1.88 PR: 234408 Submitted by: lightside <lightside@gmx.com> Changes: head/games/oolite/Makefile head/games/oolite/distinfo head/games/oolite/files/patch-deps_mozilla-bug771281
Committed, thanks!