Bug 234493 - shells/fish: Upgrade to 3.0.0
Summary: shells/fish: Upgrade to 3.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Alan Somers
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2018-12-29 19:09 UTC by Alan Somers
Modified: 2018-12-31 21:41 UTC (History)
2 users (show)

See Also:
asomers: maintainer-feedback+

Attachments
Upgrade to 3.0.0 (31.11 KB, patch)
2018-12-29 19:28 UTC, Alan Somers 		asomers: maintainer-approval+
koobs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer freebsd_triage 2018-12-29 19:09:07 UTC 

    


    


      



        
          Comment 1
        

        
          Alan Somers

        

        
            freebsd_committer
            freebsd_triage
        

        
          2018-12-29 19:28:29 UTC
        

      






Created attachment 200611 [details]
Upgrade to 3.0.0

    


    


      



        
          Comment 2
        

        
          Alan Somers

        

        
            freebsd_committer
            freebsd_triage
        

        
          2018-12-29 19:30:28 UTC
        

      






brd, do you approve this change?  In addition to upgrading the version, this change switches the build system from autoconf to cmake, switches master_sites, removes a superfluous runtime dependency on python, and adds a MANPAGES knob (because doxygen is now required to build the manpages)

    


    


      



        
          Comment 3
        

        
          Kubilay Kocak

        

        
            freebsd_committer
            freebsd_triage
        

        
          2018-12-30 01:26:53 UTC
        

      






Does this pass poudriere with/without MANPAGES/DOCS/NLS options?

    


    


      



        
          Comment 4
        

        
          Alan Somers

        

        
            freebsd_committer
            freebsd_triage
        

        
          2018-12-30 01:53:31 UTC
        

      






It passes poudriere with every combination of options on 12.0 amd64.  I haven't tried 11.2 or other architectures.

    


    


      



        
          Comment 5
        

        
          Kubilay Kocak

        

        
            freebsd_committer
            freebsd_triage
        

        
          2018-12-30 02:01:23 UTC
        

      






Comment on attachment 200611 [details]
Upgrade to 3.0.0

Reviewed by: koobs (ports)
Approved by: koobs (ports)

    


    


      



        
          Comment 6
        

        
          commit-hook

        

        
            freebsd_committer
            freebsd_triage
        

        
          2018-12-31 21:39:13 UTC
        

      






A commit references this bug:

Author: asomers
Date: Mon Dec 31 21:38:50 UTC 2018
New revision: 488840
URL: https://svnweb.freebsd.org/changeset/ports/488840

Log:
  shells/fish: upgrade to 3.0.0

  This also switches the build system from autoconf to cmake, and adds an
  on-by-default MANPAGES option.  MANPAGES are now optional because building
  them requires doxygen.

  PR:		234493
  Reviewed by:	koobs
  Approved by:	koobs (ports)

Changes:
  head/shells/fish/Makefile
  head/shells/fish/distinfo
  head/shells/fish/files/patch-cmake_Install.cmake
  head/shells/fish/files/patch-src_common.h
  head/shells/fish/files/patch-src_wgetopt.h
  head/shells/fish/pkg-plist