Bug 234526 - sysutils/xosview: remove BROKEN_FreeBSD_12
Summary: sysutils/xosview: remove BROKEN_FreeBSD_12
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2018-12-31 12:16 UTC by Helge Oldach
Modified: 2018-12-31 17:07 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (otacilio.neto)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Helge Oldach 2018-12-31 12:16:48 UTC 
According bug #230351, xosview was broken and a fix had been committed. This PR is closed. But the port still says BROKEN_FreeBSD_12 which doesn't seem to be correct. xosview actually compiles and works fine for me. Hence I suggest to remove the BROKEN_FreeBSD_12 tag.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-12-31 17:05:16 UTC 
A commit references this bug:

Author: fernape
Date: Mon Dec 31 17:04:35 UTC 2018
New revision: 488803
URL: https://svnweb.freebsd.org/changeset/ports/488803

Log:
  sysutils/xosview: update to 1.21

  No info for this new release.

  While here:

  * Remove BROKEN_* since this builds fine in 12 or greater.

  * Simplify patch since some changes where merged upstream:
  https://github.com/hills/xosview/pull/11

  PR:	234526
  Reported by:	freebsd@oldach.net

Changes:
  head/sysutils/xosview/Makefile
  head/sysutils/xosview/distinfo
  head/sysutils/xosview/files/patch-bsd_kernel.cc
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2018-12-31 17:07:14 UTC 
Thanks Helge for reporting this.

I updated the port to 1.21 and removed the BROKEN_* variables since this builds fine in 12.0 RELEASE and 13-CURRENT.

Happy New Year!