Bug 234704 - x11-toolkits/p5-Tk: Do not set CONFIGURE_ARGS twice
Summary: x11-toolkits/p5-Tk: Do not set CONFIGURE_ARGS twice
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-01-07 19:23 UTC by Tobias Kortkamp
Modified: 2019-01-07 19:28 UTC (History)
1 user (show)

See Also:
pi: maintainer-feedback+

Attachments
x11-toolkits__p5-Tk.diff (434 bytes, patch)
2019-01-07 19:23 UTC, Tobias Kortkamp 		tobik: maintainer-approval? (pi)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-07 19:23:44 UTC 
Created attachment 200882 [details]
x11-toolkits__p5-Tk.diff

The port currently sets CONFIGURE_ARGS twice like this

CONFIGURE_ARGS= X11INC=${LOCALBASE}/include X11LIB=${LOCALBASE}/lib
[...]
.if ${PORT_OPTIONS:MXFT}
CONFIGURE_ARGS= XFT=1
USE_XORG+=      xft
.else
CONFIGURE_ARGS= XFT=0
.endif

Since the second CONFIGURE_ARGS= overwrites the first, X11INC and
X11LIB are not in CONFIGURE_ARGS.  The port builds fine anyway, so
I think the first line should be removed for clarity's sake.
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2019-01-07 19:27:29 UTC 
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-01-07 19:28:22 UTC 
A commit references this bug:

Author: pi
Date: Mon Jan  7 19:27:30 UTC 2019
New revision: 489609
URL: https://svnweb.freebsd.org/changeset/ports/489609

Log:
  x11-toolkits/p5-Tk: Do not set CONFIGURE_ARGS twice

  The port currently sets CONFIGURE_ARGS twice.

  The second CONFIGURE_ARGS= overwrites the first, therefore X11INC and
  X11LIB are not in CONFIGURE_ARGS. The ports builds anyway, so
  the first CONFIGURE_ARGS can be removed.

  PR:		234704
  Submitted by:	tobik

Changes:
  head/x11-toolkits/p5-Tk/Makefile