Bug 234935 - www/py-selenium: fix/tweak dependencies
Summary: www/py-selenium: fix/tweak dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-14 12:54 UTC by Dmitry Marakasov
Modified: 2019-01-14 20:19 UTC (History)
1 user (show)

See Also:
douglas: maintainer-feedback+

Attachments
Patch (928 bytes, patch)
2019-01-14 12:54 UTC, Dmitry Marakasov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2019-01-14 12:54:01 UTC 
Created attachment 201117 [details]
Patch

- Add missing urllib3 dependency

...
    from selenium import webdriver
  File "/usr/local/lib/python3.7/site-packages/selenium/webdriver/__init__.py", line 18, in <module>
    from .firefox.webdriver import WebDriver as Firefox  # noqa
  File "/usr/local/lib/python3.7/site-packages/selenium/webdriver/firefox/webdriver.py", line 29, in <module>
    from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver
  File "/usr/local/lib/python3.7/site-packages/selenium/webdriver/remote/webdriver.py", line 27, in <module>
    from .remote_connection import RemoteConnection
  File "/usr/local/lib/python3.7/site-packages/selenium/webdriver/remote/remote_connection.py", line 24, in <module>
    import urllib3
ModuleNotFoundError: No module named 'urllib3'

- Tweak optional dependencies:
  - Add geckodriver dependency for FIREFOX, selenium won't work with just firefox without it
  - Add CHROMIUM option which adds dependency on chromium via bin/chromedriver
Comment 1 Douglas Thrift 2019-01-14 17:40:12 UTC 
Looks fine.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-01-14 20:19:29 UTC 
A commit references this bug:

Author: amdmi3
Date: Mon Jan 14 20:19:14 UTC 2019
New revision: 490314
URL: https://svnweb.freebsd.org/changeset/ports/490314

Log:
  - Add LICENSE_FILE
  - Add missing py-urllib3 dependency
  - For FIREFOX option, add dependency on geckodriver as well, as it's required for selenium to control firefox
  - Add CHROMIUM option, which adds dependency on chrome

  PR:		234935
  Submitted by:	amdmi3
  Approved by:	douglas@douglasthrift.net (maintainer)

Changes:
  head/www/py-selenium/Makefile