Bug 234986 - news/sabnzbdplus: Update to 2.3.7
Summary: news/sabnzbdplus: Update to 2.3.7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-16 01:50 UTC by Rob
Modified: 2019-01-29 10:57 UTC (History)
2 users (show)

See Also:
joshruehlig: maintainer-feedback+

Attachments
sabnzbdplus-2.3.7.diff (868 bytes, patch)
2019-01-16 05:27 UTC, Rob 		no flags Details | Diff
sabnzbdplus diff (updated 1-27-19) (4.66 KB, patch)
2019-01-27 14:02 UTC, joshruehlig 		joshruehlig: maintainer-approval+
Details | Diff
sabnzbdplus diff (updated 1-27-19) (1.53 KB, patch)
2019-01-27 14:05 UTC, joshruehlig 		joshruehlig: maintainer-approval+
Details | Diff
sabnzbdplus diff (updated 1-27-19) (1.49 KB, patch)
2019-01-27 14:09 UTC, joshruehlig 		joshruehlig: maintainer-approval+
Details | Diff
sabnzbdplus diff (updated 1-27-19) (1.41 KB, patch)
2019-01-27 14:13 UTC, joshruehlig 		joshruehlig: maintainer-approval+
Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob 2019-01-16 01:50:47 UTC 

    


    


      



        
          Comment 1
        

        
          joshruehlig

        

        
        

        
          2019-01-16 02:52:53 UTC
        

      






I need an attached diff to review.
Please see an example here https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231917

    


    


      



        
          Comment 2
        

        
          Rob

        

        
        

        
          2019-01-16 05:27:15 UTC
        

      






Created attachment 201179 [details]
sabnzbdplus-2.3.7.diff

added patch as requested

    


    


      



        
          Comment 3
        

        
          Rob

        

        
        

        
          2019-01-16 20:03:37 UTC
        

      






sorry its diff, not a patch.

    


    


      



        
          Comment 4
        

        
          joshruehlig

        

        
        

        
          2019-01-16 20:05:17 UTC
        

      






No problem, I think it should be fine. I'll test soon and approve if everything works as expected.

    


    


      



        
          Comment 5
        

        
          joshruehlig

        

        
        

        
          2019-01-17 17:26:04 UTC
        

      






Diff works for me. Thanks!

    


    


      



        
          Comment 6
        

        
          Rob

        

        
        

        
          2019-01-18 00:35:41 UTC
        

      






Great!

    


    


      



        
          Comment 7
        

        
          Rob

        

        
        

        
          2019-01-26 23:08:55 UTC
        

      






I hope you commit this change soon. It's been over a week since last comment.

    


    


      



        
          Comment 8
        

        
          Jochen Neumeister

        

        
            freebsd_committer
            freebsd_triage
        

        
          2019-01-27 09:59:08 UTC
        

      






can you pls check it with "portlint -AC"?

I see this warnings:

portlint -AC
WARN: Makefile: [17]: USE_* seen before USES.  According to the porters-handbook, USES must appear first.
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [320]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [321]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [322]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [323]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [324]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [325]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [326]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [327]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [328]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [329]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [330]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [331]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [332]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [333]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [334]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: /usr/home/joneum/dev/ports/news/sabnzbdplus/pkg-plist: [335]: installing gettext translation files, please define USES[+]=gettext as appropriate
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: "USES" has to appear earlier.
0 fatal errors and 19 warnings found.

    


    


      



        
          Comment 9
        

        
          joshruehlig

        

        
        

        
          2019-01-27 14:02:29 UTC
        

      






Created attachment 201447 [details]
sabnzbdplus diff (updated 1-27-19)

This should fix the portlint issues you found.

    


    


      



        
          Comment 10
        

        
          joshruehlig

        

        
        

        
          2019-01-27 14:05:12 UTC
        

      






Created attachment 201448 [details]
sabnzbdplus diff (updated 1-27-19)

Whoops, ignore that last file. I accidentally uploaded an old diff on my computer. Use this one instead.

    


    


      



        
          Comment 11
        

        
          joshruehlig

        

        
        

        
          2019-01-27 14:09:33 UTC
        

      






Created attachment 201449 [details]
sabnzbdplus diff (updated 1-27-19)

Sorry, another update, had to change spaces to tabs.

    


    


      



        
          Comment 12
        

        
          joshruehlig

        

        
        

        
          2019-01-27 14:13:52 UTC
        

      






Created attachment 201450 [details]
sabnzbdplus diff (updated 1-27-19)

Sorry, the automated port stamp was being changed. I probably shouldn't be working on this in the middle of the night without sleep =/
Life with a newborn...

Hopefully this diff is 100% correct.

    


    


      



        
          Comment 13
        

        
          commit-hook

        

        
            freebsd_committer
            freebsd_triage
        

        
          2019-01-29 10:57:09 UTC
        

      






A commit references this bug:

Author: joneum
Date: Tue Jan 29 10:56:15 UTC 2019
New revision: 491553
URL: https://svnweb.freebsd.org/changeset/ports/491553

Log:
  Update to 2.3.7

  PR:		234986
  Reported by:	Rob <robin@chee.ma>
  Approved by:	maintainer
  Sponsored by:	Netzkommune GmbH

Changes:
  head/news/sabnzbdplus/Makefile
  head/news/sabnzbdplus/distinfo

    


    


      



        
          Comment 14
        

        
          Jochen Neumeister

        

        
            freebsd_committer
            freebsd_triage
        

        
          2019-01-29 10:57:22 UTC
        

      






Landed. Thx :-)