Bug 235105 - chinese/pyzy: fix build with GCC-based architectures
Summary: chinese/pyzy: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-21 12:09 UTC by Piotr Kubaj
Modified: 2019-01-23 08:12 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (henry.hu.sh)

Attachments
patch (807 bytes, patch)
2019-01-21 12:09 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-01-21 12:09:43 UTC 
Created attachment 201306 [details]
patch

GCC 8 has errors like:
DoublePinyinTable.h:86:1: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
DoublePinyinTable.h:86:1: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
DoublePinyinTable.h:86:1: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
DoublePinyinTable.h:86:1: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]

Add -Wno-error=narrowing when the architecture has base GCC (and thus uses new GCC from ports).

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-01-23 08:12:36 UTC 
A commit references this bug:

Author: linimon
Date: Wed Jan 23 08:12:06 UTC 2019
New revision: 491022
URL: https://svnweb.freebsd.org/changeset/ports/491022

Log:
  Add -Wno-error=narrowing when the architecture has base GCC (and thus
  uses new GCC from ports) to prevent the following:

  DoublePinyinTable.h:86:1: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]

  While here, pet portlint.

  PR:		235105
  Submitted by:	Piotr Kubaj
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/chinese/pyzy/Makefile