Bug 235255 - sysutils/password-store: place extension in libexec instead of lib
Summary: sysutils/password-store: place extension in libexec instead of lib
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-27 20:48 UTC by Tobias Rehbein
Modified: 2019-01-30 19:48 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (rene)

Attachments
patch that places the extension directory under libexec instead of lib (659 bytes, patch)
2019-01-27 20:48 UTC, Tobias Rehbein 		no flags Details | Diff
patch that places executables in dedicated libexec subdirectory (2.63 KB, patch)
2019-01-29 18:59 UTC, Tobias Rehbein 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Rehbein 2019-01-27 20:48:29 UTC 
Created attachment 201463 [details]
patch that places the extension directory under libexec instead of lib

Hi,

I am currently working on a port for the pass-audit extension. This is why I noticed, that the pass shell script is looking for its extensions in $PREFIX/lib/password-store/extensions.

As extensions are executables I think that $PREFIX/libexec/password-store/extensions might be the better place. What do you think?

Please find attached the according patch.

I have a working port for pass-audit and just need to know where to place the executable. So I figured it would be good idea to ask the maintainer.

Best regards,

Tobias
Comment 1 Tobias Rehbein 2019-01-28 21:57:01 UTC 
Thinking about this I noticed that this port uses other files that are already placed in libexec. I guess it would be best to relocate them to libexec/password-store too.

I will provide a corresponding patch tomorrow.
Comment 2 Tobias Rehbein 2019-01-29 18:59:53 UTC 
Created attachment 201514 [details]
patch that places executables in dedicated libexec subdirectory

Find attached a patch that moves all executables in libexec into a dedicated subdirectory. While here create the extensions directory, enabling extension ports to use it.
Comment 3 Tobias Rehbein 2019-01-29 21:36:44 UTC 
One last update from my side: poudriere testport succeeded without any problems.
Comment 4 Rene Ladan freebsd_committer freebsd_triage 2019-01-29 21:47:26 UTC 
Yes, libexec would be a better place than lib, because according to hier(7) lib is for libraries and libexec is for helper executables.
Comment 5 Rene Ladan freebsd_committer freebsd_triage 2019-01-30 19:48:11 UTC 
Committed, thanks for the idea.
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-01-30 19:48:52 UTC 
A commit references this bug:

Author: rene
Date: Wed Jan 30 19:47:49 UTC 2019
New revision: 491655
URL: https://svnweb.freebsd.org/changeset/ports/491655

Log:
  sysutils/password-store: install extensions into libexec instead of lib

  This is more in line with hier(7)

  PR:		235255
  Submitted by:	tobias.rehbein@web.de

Changes:
  head/sysutils/password-store/Makefile
  head/sysutils/password-store/files/pass.in
  head/sysutils/password-store/pkg-plist