Bug 235284 - x11-wm/i3: Update to 4.16.1
Summary: x11-wm/i3: Update to 4.16.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Baptiste Daroussin
URL: https://github.com/i3/i3/releases/tag...
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-28 19:39 UTC by Dmitri Goutnik
Modified: 2019-02-22 23:44 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bapt)

Attachments
i3-4.16.1.patch (817 bytes, patch)
2019-01-28 19:39 UTC, Dmitri Goutnik 		dmgk: maintainer-approval? (bapt)
 Details | Diff
i3-misc.patch (1.63 KB, patch)
2019-01-28 20:05 UTC, Dmitri Goutnik 		dmgk: maintainer-approval? (bapt)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2019-01-28 19:39:58 UTC 
Created attachment 201486 [details]
i3-4.16.1.patch

- Update 4.16 -> 4.16.1

Changelog: https://github.com/i3/i3/blob/4.16.1/RELEASE-NOTES-4.16.1

QA:
  poudriere testport: OK (112a, 112i, 120a)
Comment 1 Dmitri Goutnik freebsd_committer freebsd_triage 2019-01-28 20:05:52 UTC 
Created attachment 201489 [details]
i3-misc.patch

While here also

- add LICENSE_FILE
- sort LIB_DEPENDS, RUN_DEPENDS and USES
- add USES=gnome/USE_GNOME=glib20 and USES=gettext-runtime (fixes stage-qa warnings)
Comment 2 Baptiste Daroussin freebsd_committer freebsd_triage 2019-01-29 08:58:10 UTC 
Thanks, the glib20 dependency is wrong
Sorting dependencies isn't any useful but why not.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-01-29 08:59:38 UTC 
A commit references this bug:

Author: bapt
Date: Tue Jan 29 08:59:31 UTC 2019
New revision: 491547
URL: https://svnweb.freebsd.org/changeset/ports/491547

Log:
  Update to 4.16.1
  Add LICENSE_FILE
  Sort dependencies
  Sort USES
  Add USES=localbase

  PR:		235284
  Submitted by:	dg@syrec.org

Changes:
  head/x11-wm/i3/Makefile
  head/x11-wm/i3/distinfo
Comment 4 Baptiste Daroussin freebsd_committer freebsd_triage 2019-01-29 09:01:09 UTC 
also LDFLAGS had to stay for ${ICONV_LIB}
Comment 5 Dmitri Goutnik freebsd_committer freebsd_triage 2019-02-22 23:44:18 UTC 
(In reply to Baptiste Daroussin from comment #2)

$ readelf -d ./work/stage/usr/local/bin/i3 | grep glib
 0x0000000000000001 NEEDED               Shared library: [libglib-2.0.so.0]

glib usage was depending on PANGO_SUPPORT but was made unconditional by 0e73a6e [1]

[1] https://github.com/i3/i3/commit/0e73a6e9e7dcc0a01b8666f85bc279a72f7c5936#diff-07e878c70a7e5be91d507d47c5e19f1f