Bug 235498 - devel/google-perftools: fix build with GCC-based architectures
Summary: devel/google-perftools: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-04 16:20 UTC by Piotr Kubaj
Modified: 2019-02-06 08:03 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
patch (3.28 KB, patch)
2019-02-04 16:20 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-02-04 16:20:11 UTC 
Created attachment 201724 [details]
patch

This port requires USES=compiler:c11 to build on GCC architectures.

Additionally, fix accessing PC register by adding appriopriate check to configure, and fix mr assembly command to FreeBSD syntax.

PRs sent at https://github.com/gperftools/gperftools/pull/1082 and https://github.com/gperftools/gperftools/pull/1083.

Note that to allow access PC register on sparc64 another configure entry needs to be added, so this port will fail to package, but I don't have sparc64 hardware to test it.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2019-02-06 08:02:45 UTC 
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-02-06 08:03:14 UTC 
A commit references this bug:

Author: yuri
Date: Wed Feb  6 08:02:44 UTC 2019
New revision: 492292
URL: https://svnweb.freebsd.org/changeset/ports/492292

Log:
  devel/google-perftools: fix build with GCC-based architectures

  PR:		235498
  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>

Changes:
  head/devel/google-perftools/Makefile
  head/devel/google-perftools/files/patch-configure
  head/devel/google-perftools/files/patch-src_stacktrace__powerpc-darwin-inl.h