Bug 235512 - math/rexx-regmath: fix build with GCC-based architectures
Summary: math/rexx-regmath: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-05 07:13 UTC by Piotr Kubaj
Modified: 2019-02-06 00:08 UTC (History)
2 users (show)

See Also:
bob: maintainer-feedback+

Attachments
patch (1.58 KB, patch)
2019-02-05 07:13 UTC, Piotr Kubaj 		tobik: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-02-05 07:13:08 UTC 
Created attachment 201741 [details]
patch

Base GCC doesn't support -Wno-incompatible-pointer-types, which breaks building on GCC architectures. Add -Wno-incompatible-pointer-types only when using Clang.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Bob Eager 2019-02-05 08:44:02 UTC 
Approved by maintainer. Can this be added directly, or should I submit a separate PR?
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2019-02-05 10:35:25 UTC 
This needs to be picked up by some commiter.
Comment 3 Bob Eager 2019-02-05 11:30:32 UTC 
Comment on attachment 201741 [details]
patch

Patch approved by maintainer.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-02-06 00:08:25 UTC 
A commit references this bug:

Author: linimon
Date: Wed Feb  6 00:08:09 UTC 2019
New revision: 492278
URL: https://svnweb.freebsd.org/changeset/ports/492278

Log:
  Base GCC doesn't support -Wno-incompatible-pointer-types, which breaks
  building on GCC-based architectures.  Add -Wno-incompatible-pointer-types
  only when using Clang.

  PR:		235512
  Submitted by:	Piotr Kubaj
  Approved by:	maintainer

Changes:
  head/math/rexx-regmath/Makefile
  head/math/rexx-regmath/files/patch-Makefile.bsd