Bug 235689 - sysutils/powerdxx: fix build with GCC-based architectures
Summary: sysutils/powerdxx: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexandre C. Guimarães
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-12 10:54 UTC by Piotr Kubaj
Modified: 2019-02-21 04:15 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (rigoletto)

Attachments
patch (350 bytes, patch)
2019-02-12 10:54 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-02-12 10:54:27 UTC 
Created attachment 201950 [details]
patch

Add -Wno-error=sign-compare to CXXFLAGS to ignore the following error when compiling with GCC:
/wrkdirs/usr/ports/sysutils/powerdxx/work/powerdxx-0.4.0/src/loadrec.cpp: In lambda function:
/wrkdirs/usr/ports/sysutils/powerdxx/work/powerdxx-0.4.0/src/loadrec.cpp:294:21: error: comparison of integer expressions of different signedness: 'int' and 'const long unsigned int' [-Werror=sign-compare]
   for (int i = 0; i < columns; ++i) {
                   ~~^~~~~~~~~
cc1plus: all warnings being treated as errors

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-02-21 04:15:12 UTC 
A commit references this bug:

Author: linimon
Date: Thu Feb 21 04:14:15 UTC 2019
New revision: 493485
URL: https://svnweb.freebsd.org/changeset/ports/493485

Log:
  Add -Wno-error=sign-compare to CXXFLAGS to ignore the following error
  when compiling with GCC:

    /wrkdirs/usr/ports/sysutils/powerdxx/work/powerdxx-0.4.0/src/loadrec.cpp: In lambda function:
    /wrkdirs/usr/ports/sysutils/powerdxx/work/powerdxx-0.4.0/src/loadrec.cpp:294:21: error: comparison of integer expressions of different signedness: 'int' and 'const long unsigned int' [-Werror=sign-compare]

  PR:		235689
  Submitted by:	Piotr Kubaj
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/sysutils/powerdxx/Makefile