Bug 235869 - converters/pecl-igbinary: Latest update causes build failures in several pecl ports
Summary: converters/pecl-igbinary: Latest update causes build failures in several pecl...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords: easy, patch, regression
Depends on:
Blocks:
 
Reported: 2019-02-19 22:39 UTC by Artyom Davidov
Modified: 2019-02-20 22:07 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
proposed patch for the Makefile (501 bytes, patch)
2019-02-20 00:23 UTC, Artyom Davidov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Artyom Davidov 2019-02-19 22:39:52 UTC 
Latest igbinary update breaks support for igbibary protocol in other pecl/php ports.
pecl-memcached, pecl-redis and maybe some other ports are unable to find "src/php7/igbinary.h" and fails to build properly.
The following error is being displayed during pecl-memcached build with enabled igbinary support:
-------
--- php_memcached.lo ---
In file included from /construction/xports/databases/pecl-memcached/work-php72/memcached-3.1.3/php_memcached.c:50:
/usr/local/include/php/ext/igbinary/igbinary.h:5:10: fatal error: 'src/php7/igbinary.h' file not found
#include "src/php7/igbinary.h"
         ^~~~~~~~~~~~~~~~~~~~~
1 error generated.
*** [php_memcached.lo] Error code 1
-------
Comment 1 Artyom Davidov 2019-02-20 00:23:30 UTC 
Created attachment 202171 [details]
proposed patch for the Makefile

This patch will bring back post-patch activity needed to compile other ports with igbinary support, that were removed in the previous commit.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-02-20 04:44:22 UTC 
* CC pecl-redis maintainer
* pecl-memcache is deprecated (due to php 5.6 eol)
Comment 3 Artyom Davidov 2019-02-20 15:01:07 UTC 
(In reply to Kubilay Kocak from comment #2)
Hello Kubilay,

Please take a note that there are two ports - one is pecl-memcache and it is deprecated, and another one is pecl-memcached that is fully supported with php7.

Also igbinary support is not enabled by default in pecl-redis and pecl-memcached ports. But they will need some header files from pecl-igbinary port to successfully compile when such support is enabled.

wbr,
Artyom
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-02-20 20:49:03 UTC 
A commit references this bug:

Author: sunpoet
Date: Wed Feb 20 20:48:02 UTC 2019
New revision: 493460
URL: https://svnweb.freebsd.org/changeset/ports/493460

Log:
  Fix build of the dependent ports

  - Bump PORTREVISION for package change

  Restore the hack (replacement of igbinary.h and php_igbinary.h) in previous versions.

  PR:		235869
  Submitted by:	Artyom Davidov <ard_1@mail.ru>

Changes:
  head/converters/pecl-igbinary/Makefile
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-02-20 20:50:50 UTC 
Committed. Thanks!
Comment 6 Artyom Davidov 2019-02-20 22:07:29 UTC 
(In reply to Sunpoet Po-Chuan Hsieh from comment #5)

Thank you, Sunpoet!

But I guess I should mention that it is not really a hack - those files aren't being replaced - they are being copied to the PHP build tree. And these files are being referenced in the files installed by this port in "include/php/ext/igbinary" directory. So we just following the upstream logic of placing these files in the directory structure.

wbr,
Artyom