- Update to version 1.0.6 - Move XORG_CAT before USE_XORG This release adds some symlinks to the whiteglass cursor theme to provide additional cursor names that gnome-shell expects, so that gnome-shell doesn't crash when trying to use those cursors. Release announcement: https://lists.x.org/archives/xorg/2019-February/059607.html
Created attachment 202260 [details] Patch file generated with svn diff
Created attachment 202261 [details] Poudriere log
Please also note: • portlint warns me about installing icons without INSTALLS_ICONS. Setting this would require to set USE_GNOME which in turn would add unwelcome dependencies, so I ignored this warning. • Poudriere gives me: pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:12:amd64" -- no architecture specific files found: **** could this package use a wildcard architecture? The latter has been discussed in https://lists.freebsd.org/pipermail/freebsd-ports/2013-November/088040.html by FreeBSD committers in 2013.
(In reply to Samy Mahmoudi from comment #3) Hi! Regardless of portlint, we don't want INSTALL_ICONS here. Pulling in USE_GNOME brings a lot of dependencies, and it feels like it's a risk to create dependency loops as well.
A commit references this bug: Author: zeising Date: Fri Feb 22 22:18:58 UTC 2019 New revision: 493618 URL: https://svnweb.freebsd.org/changeset/ports/493618 Log: x11-themes/xcursor-themes: Update to 1.0.6 Update xcursor-themes to 1.0.6. This adds some symlinks to the whiteglass cursor theme, that gnome-shell expects. [1] Add NO_ARCH since this doesn't install any architecture specific files. [2] Remove unneded dependency on xorgproto. [2] Changelog: https://lists.x.org/archives/xorg/2019-February/059607.html PR: 235936 [1] Submitted by: Samy Mahmoudi [1], zeising [2] Sponsored by: B3 Init (zeising) Changes: head/x11-themes/xcursor-themes/Makefile head/x11-themes/xcursor-themes/distinfo head/x11-themes/xcursor-themes/pkg-plist
Committed, thanks! I added NO_ARCH, since as you noticed, no architecture specific files are installed. I also removed the USE_XORG line, since that dependency isn't needed here.
(In reply to Niclas Zeising from comment #6) > I added NO_ARCH, since as you noticed, no architecture specific files are installed. Thank you! Now I understand that pkg notice better. I submitted an addition to the documentation (Bug 235980). > I also removed the USE_XORG line, since that dependency isn't needed here. Isn't stage-qa supposed to warn me in case of unneeded dependency? Or is this warning only triggered when linking/not linking, in which case you spotted that unneeded dependency by yourself?
(In reply to Samy Mahmoudi from comment #7) stage-qa can't generally detect unneeded dependencies. It might detect that you are not linked against shared libraries that you have in LIB_DEPENDS, but as far as I know, that's it. In this specific case, xorgproto is a package with a bunch of c/c++ header files for various X protocols, and since xcursor-themes doesn't compile and install anything, I figured out it wasn't needed. This is something that the stage-qa can't know, and I only know because I've been digging around here for so long. :) Why NO_ARCH isn't documented, I don't know, but it looks like it will be fixed.
(In reply to Niclas Zeising from comment #8) ;-)